From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 1/2] thermal: tsens: Add support for SDM845 platform Date: Mon, 4 Jun 2018 08:03:19 -0700 Message-ID: <20180604150319.GC510@tuxbook-pro> References: <7a0f33cff94f41110bdbff14d28d36074fae2a7d.1527937396.git.amit.kucheria@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <7a0f33cff94f41110bdbff14d28d36074fae2a7d.1527937396.git.amit.kucheria@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Amit Kucheria Cc: linux-arm-msm@vger.kernel.org, rnayak@codeaurora.org, edubezval@gmail.com, Zhang Rui , Rob Herring , Mark Rutland , "open list:THERMAL" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org On Sat 02 Jun 04:11 PDT 2018, Amit Kucheria wrote: > diff --git a/drivers/thermal/qcom/tsens-sdm845.c b/drivers/thermal/qcom/tsens-sdm845.c [..] > +#define TRDY_OFFSET 0xe4 > +#define TRDY_READY_BIT BIT(1) This is bit 0. > + > +#define STATUS_OFFSET 0xa0 > +#define LAST_TEMP_MASK 0xfff > +#define STATUS_VALID_BIT BIT(21) > +#define CODE_SIGN_BIT BIT(11) > + > +static int get_temp_sdm845(struct tsens_device *tmdev, int id, int *temp) > +{ > + struct tsens_sensor *s = &tmdev->sensor[id]; > + u32 code; > + unsigned int sensor_addr; > + int last_temp = 0, last_temp2 = 0, last_temp3 = 0, ret; > + > + ret = regmap_read(tmdev->map, TRDY_OFFSET, &code); > + if (ret) > + return ret; > + if (code & TRDY_READY_BIT) > + return -ENODATA; This section is the only difference from 8996, but this register is identical to 8996 and 8998. So I think you should add this to tsens-8996.c and we can use that for 8996, 8998 and sdm845. Perhaps we should name it tsens-v2, as that seems to be the common denominator for these, according to the documentation. Regards, Bjorn