From: Lee Jones <lee.jones@linaro.org>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>,
devicetree <devicetree@vger.kernel.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] regulator: tps65911: fix regulator-compatible documentation
Date: Tue, 5 Jun 2018 08:04:57 +0100 [thread overview]
Message-ID: <20180605070457.GF21163@dell> (raw)
In-Reply-To: <1528146863.2818.23.camel@googlemail.com>
On Mon, 04 Jun 2018, Christoph Fritz wrote:
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
> Documentation/devicetree/bindings/mfd/tps65910.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/tps65910.txt b/Documentation/devicetree/bindings/mfd/tps65910.txt
> index 8af1202..4f62143 100644
> --- a/Documentation/devicetree/bindings/mfd/tps65910.txt
> +++ b/Documentation/devicetree/bindings/mfd/tps65910.txt
> @@ -22,7 +22,7 @@ Required properties:
> The valid regulator-compatible values are:
> tps65910: vrtc, vio, vdd1, vdd2, vdd3, vdig1, vdig2, vpll, vdac, vaux1,
> vaux2, vaux33, vmmc, vbb
> - tps65911: vrtc, vio, vdd1, vdd3, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
> + tps65911: vrtc, vio, vdd1, vdd2, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
> ldo6, ldo7, ldo8
>
> - xxx-supply: Input voltage supply regulator.
<playing_dumb>
I have no idea what I'm meant to be looking for.
Please add a suitable commit log.
</playing_dumb>
Also, this is not a "regulator" patch, as your $SUBJECT suggests.
Please change the pre-fix to "dt-bindings: mfd: "
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-06-05 7:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 21:14 [PATCH] regulator: tps65911: fix regulator-compatible documentation Christoph Fritz
2018-06-05 7:04 ` Lee Jones [this message]
2018-06-05 9:26 ` [PATCH v2] dt-bindings: mfd: fix documentation of tps65911 Christoph Fritz
2018-06-11 18:27 ` Rob Herring
2018-06-23 19:26 ` Christoph Fritz
2018-07-03 7:41 ` Lee Jones
2018-07-04 7:41 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605070457.GF21163@dell \
--to=lee.jones@linaro.org \
--cc=chf.fritz@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).