From: Shawn Guo <shawnguo@kernel.org>
To: Bai Ping <ping.bai@nxp.com>
Cc: aisheng.dong@nxp.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
jacky.baip@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 2/2] ARM: dts: imx: Add basic dts support for imx6sll EVK board
Date: Mon, 11 Jun 2018 16:24:13 +0800 [thread overview]
Message-ID: <20180611082411.GH16091@dragon> (raw)
In-Reply-To: <1527234127-11991-2-git-send-email-ping.bai@nxp.com>
On Fri, May 25, 2018 at 03:42:07PM +0800, Bai Ping wrote:
> Add dts file support for imx6sll EVK board.
>
> Signed-off-by: Bai Ping <ping.bai@nxp.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Acked-by: Dong Aisheng <Aisheng.dong@nxp.com>
> ---
> change v3->v4
> - update the license indentifier
> - remove leading zero of node
> - remove unused pin from hog group
> change v4->v5
> - use generic name for device node
> - remove unnecessary hog pin group
> change v5->v6
> - no
> change v6->v7
> - move the iomuxc node to the end of dts file
> ---
> Documentation/devicetree/bindings/arm/fsl.txt | 4 +
> arch/arm/boot/dts/Makefile | 2 +
> arch/arm/boot/dts/imx6sll-evk.dts | 317 ++++++++++++++++++++++++++
> 3 files changed, 323 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6sll-evk.dts
<snip>
> + pinctrl_i2c1: i2c1grp {
> + fsl,pins = <
> + MX6SLL_PAD_I2C1_SCL__I2C1_SCL 0x4001b8b1
> + MX6SLL_PAD_I2C1_SDA__I2C1_SDA 0x4001b8b1
> + >;
> + };
> +};
> +
> +
The new blank line at EOF should be dropped.
I fixed it up and applied both patches.
Shawn
prev parent reply other threads:[~2018-06-11 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 7:42 [PATCH v7 1/2] ARM: dts: imx: Add basic dtsi file for imx6sll Bai Ping
2018-05-25 7:42 ` [PATCH v7 2/2] ARM: dts: imx: Add basic dts support for imx6sll EVK board Bai Ping
2018-05-25 7:56 ` A.s. Dong
2018-06-04 5:27 ` A.s. Dong
2018-06-11 8:24 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611082411.GH16091@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jacky.baip@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).