From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Radu Pirea <radu.pirea@microchip.com>
Cc: broonie@kernel.org, nicolas.ferre@microchip.com,
lee.jones@linaro.org, richard.genoud@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
gregkh@linuxfoundation.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v6 2/6] dt-bindings: add binding for atmel-usart in SPI mode
Date: Mon, 11 Jun 2018 17:37:58 +0200 [thread overview]
Message-ID: <20180611153758.GH10521@piout.net> (raw)
In-Reply-To: <20180607110020.20565-3-radu.pirea@microchip.com>
Hi,
On 07/06/2018 14:00:16+0300, Radu Pirea wrote:
> diff --git a/include/dt-bindings/mfd/at91-usart.h b/include/dt-bindings/mfd/at91-usart.h
> new file mode 100644
> index 000000000000..ac811628a42d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/at91-usart.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * This header provides macros for AT91 USART DT bindings.
> + *
> + * Copyright (C) 2018 Microchip Technology
> + *
> + * Author: Radu Pirea <radu.pirea@microchip.com>
> + *
> + */
> +
> +#ifndef __DT_BINDINGS_AT91_USART_H__
> +#define __DT_BINDINGS_AT91_USART_H__
> +
> +#define AT91_USART_MODE_SERIAL 1
> +#define AT91_USART_MODE_SPI 2
> +
Nitpick, I'd make that 0 and 1 instead of 1 and 2. That would feel more
natural to me regarding the default value.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-11 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 11:00 [PATCH v6 0/6] Driver for at91 usart in spi mode Radu Pirea
2018-06-07 11:00 ` [PATCH v6 1/6] MAINTAINERS: add at91 usart mfd driver Radu Pirea
2018-06-07 11:00 ` [PATCH v6 2/6] dt-bindings: add binding for atmel-usart in SPI mode Radu Pirea
2018-06-11 15:37 ` Alexandre Belloni [this message]
2018-06-07 11:00 ` [PATCH v6 3/6] mfd: at91-usart: added mfd driver for usart Radu Pirea
2018-06-11 15:36 ` Alexandre Belloni
2018-06-07 11:00 ` [PATCH v6 4/6] MAINTAINERS: add at91 usart spi driver Radu Pirea
2018-06-07 11:00 ` [PATCH v6 5/6] spi: at91-usart: add driver for at91-usart as spi Radu Pirea
2018-06-07 11:00 ` [PATCH v6 6/6] tty/serial: atmel: change the driver to work under at91-usart mfd Radu Pirea
2018-06-07 13:42 ` Richard Genoud
2018-06-07 13:18 ` [PATCH v6 0/6] Driver for at91 usart in spi mode Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611153758.GH10521@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=radu.pirea@microchip.com \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).