From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 12 Jun 2018 09:30:31 +0530 From: Vinod Subject: Re: [v5 2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Message-ID: <20180612040031.GI2452@vkoul-mobl> References: <20180525111920.24498-1-wen.he_1@nxp.com> <20180525111920.24498-2-wen.he_1@nxp.com> <20180605163043.GX16230@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Li Yang Cc: Wen He , "dmaengine@vger.kernel.org" , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jiafei Pan , Jiaheng Fan List-ID: On 05-06-18, 12:24, Li Yang wrote: > On Tue, Jun 5, 2018 at 11:30 AM, Vinod wrote: > > On 04-06-18, 09:53, Wen He wrote: > > > >> > >> > > +// SPDX-License-Identifier: GPL-2.0 > >> > > +// Copyright 2018 NXP > >> > > >> > I know the SPDX tag is recommended to be the 1st line, but copyright normally > >> > goes below the file description not above. > > > > I do not think that is specified anywhere.. can you point it? > > No. It is not documented. But the majority of the source files in > Linux are using this header format like below, so I assume it is > something like a convention. > > /* > * {filename --} file description > * > * Copyright ... > * > * License ... > */ > > The Documentation/process/license-rules.rst only mentioned about the > requirement for SPDX tags. So I think we should keep the format for > other part of the header. And Linus said this https://lkml.org/lkml/2017/11/25/133 -- ~Vinod