From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Stefan Popa <stefan.popa@analog.com>,
Michael.Hennerich@analog.com, lars@metafoo.de, knaack.h@gmx.de,
pmeerw@pmeerw.net, mark.rutland@arm.com, mchehab@kernel.org,
davem@davemloft.net, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, linus.walleij@linaro.org,
rdunlap@infradead.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC
Date: Tue, 12 Jun 2018 12:21:33 -0600 [thread overview]
Message-ID: <20180612182133.GA3118@rob-hp-laptop> (raw)
In-Reply-To: <20180610145923.3b767ad4@archlinux>
On Sun, Jun 10, 2018 at 02:59:23PM +0100, Jonathan Cameron wrote:
> On Thu, 7 Jun 2018 16:11:05 +0300
> Stefan Popa <stefan.popa@analog.com> wrote:
>
> > Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> Hmm. The first part number I've ever googled where the top hit has
> been a flight number.
> Rio de Janeiro to Campinas is apparently on time today.
>
> > ---
> > Changes in v2:
> > - Nothing changed, just to follow the patch set version.
> >
> > .../devicetree/bindings/iio/dac/ad5758.txt | 84 ++++++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 85 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/ad5758.txt b/Documentation/devicetree/bindings/iio/dac/ad5758.txt
> > new file mode 100644
> > index 0000000..75fff6c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/ad5758.txt
> > @@ -0,0 +1,84 @@
> > +Analog Devices AD5758 DAC device driver
> > +
> > +Required properties for the AD5758:
> > + - compatible: Must be "adi,ad5758"
> > + - reg: SPI chip select number for the device
> > + - spi-max-frequency: Max SPI frequency to use (< 50000000)
> > + - spi-cpha: is the only mode that is supported
> > +
> > +Optional properties:
> > +
> > + - adi,dc-dc-mode: Mode of operation of the dc-to-dc converter
> > + The following values are currently supported:
> > + * 0: DC-to-DC converter powered off
> > + * 1: DPC current mode
> Perhaps expand those acronyms?
> Dynamic Power Control and perhaps a bit of explanation so people
> who are ready DT files don't have to go find the data sheet to have
> some idea of what these are?
>
> Otherwise, binding is fine.
>
> > + * 2: DPC voltage mode
> > + * 3: PPC current mode
> > +
> > + - adi,dc-dc-ilim: The dc-to-dc converter current limit
> > + The following values are currently supported [mA]:
> Unit should be in the name.
> adi,dc-dc-ilim_ma
Yes, but don't use '_' and follow what is in property-units.txt.
next prev parent reply other threads:[~2018-06-12 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 13:11 [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC Stefan Popa
2018-06-10 13:59 ` Jonathan Cameron
2018-06-12 18:21 ` Rob Herring [this message]
2018-06-11 8:42 ` Linus Walleij
2018-06-16 17:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612182133.GA3118@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rdunlap@infradead.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox