From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [RFC PATCH 3/6] serial: 8250_omap: Add support for AM654 UART controller Date: Tue, 12 Jun 2018 17:03:33 -0500 Message-ID: <20180612220333.4odussbccwmup26v@kahuna> References: <20180605060125.9518-1-nm@ti.com> <20180605060125.9518-4-nm@ti.com> <20180612210640.GA20728@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180612210640.GA20728@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, Sudeep Holla , Vignesh R , Tony Lindgren , Catalin Marinas , Santosh Shilimkar , Will Deacon , linux-kernel@vger.kernel.org, Sekhar Nori , Russell King , Tero Kristo , linux-serial@vger.kernel.org, Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 21:06-20180612, Rob Herring wrote: > > diff --git a/Documentation/devicetree/bindings/serial/omap_serial.txt b/Documentation/devicetree/bindings/serial/omap_serial.txt > > index 4b0f05adb228..c35d5ece1156 100644 > > --- a/Documentation/devicetree/bindings/serial/omap_serial.txt > > +++ b/Documentation/devicetree/bindings/serial/omap_serial.txt > > @@ -1,6 +1,7 @@ > > OMAP UART controller > > > > Required properties: > > +- compatible : should be "ti,am654-uart" for AM654 controllers > > Not compatible with any existing TI 8250 UARTs? Base is compatible, however there are differences in DMA operation and few additional bits. omap4-uart is sufficient for a basic PIO mode of operation given initialization a bootloader might do for base console. I will split the bindings off into it's own patch to keep the confusion to a minimum and allowing serial driver change to go in independently. -- Regards, Nishanth Menon