From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex Date: Tue, 12 Jun 2018 16:13:59 -0600 Message-ID: <20180612221359.GA26741@rob-hp-laptop> References: <20180611202211.15501-1-robert.jarzmik@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180611202211.15501-1-robert.jarzmik@free.fr> Sender: linux-kernel-owner@vger.kernel.org To: Robert Jarzmik Cc: Liam Girdwood , Mark Brown , Mark Rutland , Daniel Mack , Haojian Zhuang , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: > This adds a binding for the Marvell PXA audio complex, available in > pxa2xx and pxa3xx variants. > > Signed-off-by: Robert Jarzmik > --- > .../bindings/sound/marvell,pxa2xx-ac97.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/marvell,pxa2xx-ac97.txt > > diff --git a/Documentation/devicetree/bindings/sound/marvell,pxa2xx-ac97.txt b/Documentation/devicetree/bindings/sound/marvell,pxa2xx-ac97.txt > new file mode 100644 > index 000000000000..b3f2882d9c7d > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/marvell,pxa2xx-ac97.txt > @@ -0,0 +1,25 @@ > +Marvell PXA2xx audio complex > + > +This descriptions matches the AC97 controller found in pxa2xx and pxa3xx series. > + > +Required properties: > + - compatible: "marvell,pxa2xx-ac97" Don't use wildcards in compatible strings. Though this is so old... > + - reg: device MMIO address space > + - interrupts: single interrupt generated by AC97 IP > + - clocks: input clock of the AC97 IP, refer to clock-bindings.txt > + > +Optional properties: > + - pinctrl-names, pinctrl-0: refer to pinctrl-bindings.txt > + - reset-gpio: gpio used for AC97 reset, refer to gpio.txt reset-gpios > + > +Example: > + ac97: sound@40500000 { > + compatible = "marvell,pxa2xx-ac97"; > + reg = < 0x40500000 0x1000 >; > + interrupts = <14>; > + reset-gpio = <&gpio 113 GPIO_ACTIVE_HIGH>; > + #sound-dai-cells = <1>; > + pinctrl-names = "default"; > + pinctrl-0 = < &pmux_ac97_default >; > + status = "okay"; Don't show status in examples. > + }; > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html