* [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c
@ 2018-06-13 17:50 Douglas Anderson
2018-06-22 16:51 ` Bjorn Andersson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Douglas Anderson @ 2018-06-13 17:50 UTC (permalink / raw)
To: andy.gross, bjorn.andersson
Cc: kramasub, wsa, Douglas Anderson, devicetree, linux-arm-msm,
linux-kernel, Rob Herring, David Brown, Mark Rutland, linux-soc
In an early version of the I2C patch that was posted to the list the
default I2C frequency (if none was specified) was 400 kHz. There was
debate on the list and we decided that it would be more consistent
with the rest of i2c if we defaulted to 100 kHz. ...but we never
updated the bindings. Let's fix this.
NOTE: since the i2c driver itself hasn't actually landed yet and the
SoC here is very new it seems terribly unlikely that anyone was
relying on the old 400 kHz number, so I'll assume this is an OK
"incompatible" device tree change.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
index d330c73de9a2..68b7d6207e3d 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
@@ -39,7 +39,7 @@ Required properties:
Optional property:
- clock-frequency: Desired I2C bus clock frequency in Hz.
- When missing default to 400000Hz.
+ When missing default to 100000Hz.
Child nodes should conform to I2C bus binding as described in i2c.txt.
--
2.18.0.rc1.244.gcf134e6275-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c
2018-06-13 17:50 [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c Douglas Anderson
@ 2018-06-22 16:51 ` Bjorn Andersson
2018-06-23 15:16 ` Wolfram Sang
2018-06-26 19:24 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-06-22 16:51 UTC (permalink / raw)
To: Douglas Anderson
Cc: andy.gross, kramasub, wsa, devicetree, linux-arm-msm,
linux-kernel, Rob Herring, David Brown, Mark Rutland, linux-soc
On Wed 13 Jun 10:50 PDT 2018, Douglas Anderson wrote:
> In an early version of the I2C patch that was posted to the list the
> default I2C frequency (if none was specified) was 400 kHz. There was
> debate on the list and we decided that it would be more consistent
> with the rest of i2c if we defaulted to 100 kHz. ...but we never
> updated the bindings. Let's fix this.
>
> NOTE: since the i2c driver itself hasn't actually landed yet and the
> SoC here is very new it seems terribly unlikely that anyone was
> relying on the old 400 kHz number, so I'll assume this is an OK
> "incompatible" device tree change.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
>
> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> index d330c73de9a2..68b7d6207e3d 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> @@ -39,7 +39,7 @@ Required properties:
>
> Optional property:
> - clock-frequency: Desired I2C bus clock frequency in Hz.
> - When missing default to 400000Hz.
> + When missing default to 100000Hz.
>
> Child nodes should conform to I2C bus binding as described in i2c.txt.
>
> --
> 2.18.0.rc1.244.gcf134e6275-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c
2018-06-13 17:50 [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c Douglas Anderson
2018-06-22 16:51 ` Bjorn Andersson
@ 2018-06-23 15:16 ` Wolfram Sang
2018-06-26 19:24 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2018-06-23 15:16 UTC (permalink / raw)
To: Douglas Anderson
Cc: andy.gross, bjorn.andersson, kramasub, devicetree, linux-arm-msm,
linux-kernel, Rob Herring, David Brown, Mark Rutland, linux-soc
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On Wed, Jun 13, 2018 at 10:50:11AM -0700, Douglas Anderson wrote:
> In an early version of the I2C patch that was posted to the list the
> default I2C frequency (if none was specified) was 400 kHz. There was
> debate on the list and we decided that it would be more consistent
> with the rest of i2c if we defaulted to 100 kHz. ...but we never
> updated the bindings. Let's fix this.
>
> NOTE: since the i2c driver itself hasn't actually landed yet and the
> SoC here is very new it seems terribly unlikely that anyone was
> relying on the old 400 kHz number, so I'll assume this is an OK
> "incompatible" device tree change.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c
2018-06-13 17:50 [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c Douglas Anderson
2018-06-22 16:51 ` Bjorn Andersson
2018-06-23 15:16 ` Wolfram Sang
@ 2018-06-26 19:24 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2018-06-26 19:24 UTC (permalink / raw)
To: Douglas Anderson
Cc: andy.gross, bjorn.andersson, kramasub, wsa, devicetree,
linux-arm-msm, linux-kernel, David Brown, Mark Rutland, linux-soc
On Wed, Jun 13, 2018 at 10:50:11AM -0700, Douglas Anderson wrote:
> In an early version of the I2C patch that was posted to the list the
> default I2C frequency (if none was specified) was 400 kHz. There was
> debate on the list and we decided that it would be more consistent
> with the rest of i2c if we defaulted to 100 kHz. ...but we never
> updated the bindings. Let's fix this.
>
> NOTE: since the i2c driver itself hasn't actually landed yet and the
> SoC here is very new it seems terribly unlikely that anyone was
> relying on the old 400 kHz number, so I'll assume this is an OK
> "incompatible" device tree change.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-26 19:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-13 17:50 [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c Douglas Anderson
2018-06-22 16:51 ` Bjorn Andersson
2018-06-23 15:16 ` Wolfram Sang
2018-06-26 19:24 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).