From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Radu Pirea <radu.pirea@microchip.com>
Cc: broonie@kernel.org, nicolas.ferre@microchip.com,
lee.jones@linaro.org, richard.genoud@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 3/6] mfd: at91-usart: added mfd driver for usart
Date: Thu, 14 Jun 2018 10:32:20 +0200 [thread overview]
Message-ID: <20180614083220.GU10521@piout.net> (raw)
In-Reply-To: <1086330e-40e4-8d9b-50aa-1ae9bf48aa22@microchip.com>
On 14/06/2018 11:22:25+0300, Radu Pirea wrote:
> On 06/14/2018 10:58 AM, Ludovic Desroches wrote:
> > > +static int at91_usart_mode_probe(struct platform_device *pdev)
> > > +{
> > > + struct mfd_cell cell;
> > > + u32 opmode = AT91_USART_MODE_SERIAL;
> > > +
> > > + device_property_read_u32(&pdev->dev, "atmel,usart-mode", &opmode);
> > > +
> > > + switch (opmode) {
> > > + case AT91_USART_MODE_SPI:
> > > + cell = at91_usart_spi_subdev;
> > > + break;
> > > + case AT91_USART_MODE_SERIAL:
> > > + cell = at91_usart_serial_subdev;
> > > + break;
> > > + default:
> > > + break;
> >
> > If there is an invalid opmode from the DT, you will pass a non initialized cell
> > to mfd_add_device().
> >
> > Regards
> >
> > Ludovic
>
> Hi Ludovic,
>
> Tnx. That's true. How is better to do if atmel,usart-mode has an invalid
> value? To initialize cell with at91_usart_serial_subdev or to print an error
> message and return -EINVAL?
>
Returning an error is probably the correct choice because it means the
DT has an invalid value (something was done and is wrong).
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-14 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 16:36 [PATCH v7 0/6] Driver for at91 usart in spi mode Radu Pirea
2018-06-13 16:36 ` [PATCH v7 1/6] MAINTAINERS: add at91 usart mfd driver Radu Pirea
2018-06-13 16:36 ` [PATCH v7 2/6] dt-bindings: add binding for atmel-usart in SPI mode Radu Pirea
2018-06-13 16:36 ` [PATCH v7 3/6] mfd: at91-usart: added mfd driver for usart Radu Pirea
2018-06-14 7:58 ` Ludovic Desroches
2018-06-14 8:22 ` Radu Pirea
2018-06-14 8:32 ` Alexandre Belloni [this message]
2018-06-13 16:36 ` [PATCH v7 4/6] MAINTAINERS: add at91 usart spi driver Radu Pirea
2018-06-13 16:36 ` [PATCH v7 5/6] spi: at91-usart: add driver for at91-usart as spi Radu Pirea
2018-06-13 16:36 ` [PATCH v7 6/6] tty/serial: atmel: change the driver to work under at91-usart mfd Radu Pirea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614083220.GU10521@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=radu.pirea@microchip.com \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).