From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Ben Whitten <ben.whitten@gmail.com>,
devicetree@vger.kernel.org,
Ben Whitten <ben.whitten@lairdtech.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK
Date: Thu, 14 Jun 2018 15:00:28 +0200 [thread overview]
Message-ID: <20180614130028.GA16660@piout.net> (raw)
In-Reply-To: <03f0f635-3fc2-085b-20e0-e1fcaa9e8062@microchip.com>
On 14/06/2018 14:52:25+0200, Nicolas Ferre wrote:
> > + gpio_keys {
> > + compatible = "gpio-keys";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + irqbtn@pb18 {
>
> I'm not sure that the @pb18 can be used like this. This address extension
> must be used in a "reg" property in the node. dtc used with warning switch
> on might trigger an error for this.
>
Indeed, no unit-address without a reg property.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-14 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 8:51 [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK Ben Whitten
2018-06-14 8:51 ` [PATCH 2/4] arm: dts: add support for Laird WB50N " Ben Whitten
2018-06-14 9:50 ` Alexandre Belloni
2018-06-14 11:47 ` Nicolas Ferre
2018-06-14 8:51 ` [PATCH 3/4] arm: dts: add support for Gatwick board based on WB50N Ben Whitten
2018-06-14 8:51 ` [PATCH 4/4] arm: dts: add support for Laird SOM60 module and DVK boards Ben Whitten
2018-06-14 13:14 ` Nicolas Ferre
2018-06-15 8:57 ` Ben Whitten
2018-06-14 9:07 ` [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK Alexandre Belloni
2018-06-14 11:24 ` Alexandre Belloni
2018-06-14 12:52 ` Nicolas Ferre
2018-06-14 13:00 ` Alexandre Belloni [this message]
2018-06-15 10:01 ` Ben Whitten
2018-06-15 12:07 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614130028.GA16660@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=ben.whitten@gmail.com \
--cc=ben.whitten@lairdtech.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).