From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
airlied@linux.ie, wens@csie.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
robh+dt@kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-sunxi] Re: [PATCH v2 04/27] dt-bindings: display: sunxi-drm: Add TCON TOP description
Date: Fri, 15 Jun 2018 10:45:42 +0200 [thread overview]
Message-ID: <20180615084542.slp3ma4krrj744do@flea> (raw)
In-Reply-To: <2481282.yoIGH2ksVh@jernej-laptop>
[-- Attachment #1.1: Type: text/plain, Size: 1328 bytes --]
On Wed, Jun 13, 2018 at 06:03:21PM +0200, Jernej Škrabec wrote:
> > > +Required properties:
> > > + - compatible: value must be one of:
> > > + * allwinner,sun8i-r40-tcon-top
> > > + - reg: base address and size of the memory-mapped region.
> > > + - clocks: phandle to the clocks feeding the TCON TOP
> > > + * bus: TCON TOP interface clock
> > > + - clock-names: clock name mentioned above
> > > + - resets: phandle to the reset line driving the DRC
> >
> > s/DRC/TCON TOP/ ?
>
> Yes, copy & paste issue
>
> >
> > > + * rst: TCON TOP reset line
> >
> > Remaining consistent with the clock name would be great
>
> You mean "ahb"? I noticed that most other nodes with reset lines don't have a
> name associated. Maybe I could just drop it and use first specified reset?
It's called bus in the binding, but yes. And yeah, we can drop the
name as well.
> >
> > > + - reset-names: reset name mentioned above
> > > + - #clock-cells : must contain 1
> >
> > An example would be nice here
>
> You mean node example? with ports? In the past, Rob was against examples
> unless really necessary. Node from R40 DTSI can serve as an example.
Ok.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-15 8:45 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 20:00 [PATCH v2 00/27] Add support for R40 HDMI pipeline Jernej Skrabec
[not found] ` <20180612200036.21483-1-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-12 20:00 ` [PATCH v2 01/27] clk: sunxi-ng: r40: Add minimal rate for video PLLs Jernej Skrabec
[not found] ` <20180612200036.21483-2-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-13 3:18 ` Chen-Yu Tsai
2018-06-12 20:00 ` [PATCH v2 02/27] clk: sunxi-ng: r40: Allow setting parent rate to display related clocks Jernej Skrabec
[not found] ` <20180612200036.21483-3-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-13 3:19 ` Chen-Yu Tsai
2018-06-12 20:00 ` [PATCH v2 03/27] clk: sunxi-ng: r40: Export video PLLs Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 04/27] dt-bindings: display: sunxi-drm: Add TCON TOP description Jernej Skrabec
[not found] ` <20180612200036.21483-5-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-13 7:34 ` Maxime Ripard
2018-06-13 16:03 ` Jernej Škrabec
2018-06-15 8:45 ` Maxime Ripard [this message]
2018-06-12 20:00 ` [PATCH v2 05/27] drm/sun4i: Add TCON TOP driver Jernej Skrabec
2018-06-13 7:07 ` kbuild test robot
2018-06-12 20:00 ` [PATCH v2 06/27] drm/sun4i: Fix releasing node when enumerating enpoints Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 07/27] drm/sun4i: Split out code for enumerating endpoints in output port Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 08/27] drm/sun4i: Add support for traversing graph with TCON TOP Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 09/27] drm/sun4i: Don't skip TCONs if they don't have channel 0 Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 10/27] dt-bindings: display: sun4i-drm: Add R40 TV TCON description Jernej Skrabec
[not found] ` <20180612200036.21483-11-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-20 19:15 ` Rob Herring
2018-06-12 20:00 ` [PATCH v2 11/27] drm/sun4i: tcon: Add support for tcon-top gate Jernej Skrabec
[not found] ` <20180612200036.21483-12-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-15 8:31 ` Maxime Ripard
2018-06-15 16:41 ` Jernej Škrabec
2018-06-15 17:13 ` Chen-Yu Tsai
[not found] ` <CAGb2v66UFRKRF4_zbm8nQJYoOHb-iLbiU_0iYWep=WNiQDftMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-15 17:33 ` Jernej Škrabec
2018-06-16 5:48 ` Chen-Yu Tsai
[not found] ` <CAGb2v66Tv7876_heSve0zb+vWfz9kbwbrU8NjnpTwUHm6xOKJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-20 19:37 ` Jernej Škrabec
2018-06-21 1:23 ` Chen-Yu Tsai
[not found] ` <CAGb2v64iB8FP1Nf+vZM2wd6wzNLxWYrCP78D-rOUg881RPNpEA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-21 15:35 ` Jernej Škrabec
2018-06-24 19:52 ` Jernej Škrabec
2018-06-25 3:51 ` Chen-Yu Tsai
[not found] ` <CAGb2v67wVpAKk-5kSpnbnBXz7DkHToPa6bwuRBnsfHovw74HVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-25 7:58 ` Jernej Škrabec
2018-06-25 8:14 ` Chen-Yu Tsai
[not found] ` <CAGb2v676mFiOry5eQabzkyVaQ6R64gT2_XuBzTAtHorNzfwCuw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-25 9:10 ` Jernej Škrabec
2018-06-12 20:00 ` [PATCH v2 12/27] drm/sun4i: tcon: Generalize engine search algorithm Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 13/27] drm/sun4i: Don't check for LVDS and RGB when TCON has only ch1 Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 14/27] drm/sun4i: Don't check for panel or bridge on TV TCONs Jernej Skrabec
[not found] ` <20180612200036.21483-15-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-13 7:46 ` Maxime Ripard
2018-06-13 8:04 ` Chen-Yu Tsai
[not found] ` <CAGb2v66QWr2CQhcfQ9BQds-0xeG=pS4MDzaNn7_HGz+q3gfkWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-13 16:20 ` Jernej Škrabec
2018-06-12 20:00 ` [PATCH v2 15/27] drm/sun4i: Add support for R40 TV TCON Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 16/27] dt-bindings: display: sun4i-drm: Add R40 mixer compatibles Jernej Skrabec
2018-06-20 19:16 ` Rob Herring
2018-06-12 20:00 ` [PATCH v2 17/27] drm/sun4i: Add support for R40 mixers Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 18/27] dt-bindings: display: sun4i-drm: Add description of A64 HDMI PHY Jernej Skrabec
[not found] ` <20180612200036.21483-19-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-20 19:17 ` Rob Herring
2018-06-12 20:00 ` [PATCH v2 19/27] drm/sun4i: Enable DW HDMI PHY clock Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 20/27] drm/sun4i: Don't change clock bits in DW HDMI PHY driver Jernej Skrabec
[not found] ` <20180612200036.21483-21-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-15 16:44 ` Jernej Škrabec
2018-06-12 20:00 ` [PATCH v2 21/27] drm/sun4i: DW HDMI PHY: Add support for second PLL Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 22/27] drm/sun4i: Add support for second clock parent to DW HDMI PHY clk driver Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 23/27] drm/sun4i: Add support for A64 HDMI PHY Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 24/27] drm: of: Export drm_crtc_port_mask() Jernej Skrabec
[not found] ` <20180612200036.21483-25-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2018-06-13 7:36 ` Maxime Ripard
2018-06-13 16:04 ` Jernej Škrabec
2018-06-12 20:00 ` [PATCH v2 25/27] drm/sun4i: DW HDMI: Expand algorithm for possible crtcs Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 26/27] ARM: dts: sun8i: r40: Add HDMI pipeline Jernej Skrabec
2018-06-12 20:00 ` [PATCH v2 27/27] ARM: dts: sun8i: r40: Enable HDMI output on BananaPi M2 Ultra Jernej Skrabec
2018-06-14 7:12 ` [PATCH v2 00/27] Add support for R40 HDMI pipeline Jagan Teki
[not found] ` <CAMty3ZC-Edg5XJQpqEuwLbSFzmam3zP3zUPak4K7ypyT2+arAg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-14 14:34 ` Jernej Škrabec
2018-06-14 17:16 ` Jagan Teki
[not found] ` <CAMty3ZBt33q9HWm7n3SrON_Y51g+bsQNfoHajCCVzuKZLGHkjw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-14 17:29 ` Jernej Škrabec
2018-06-18 12:58 ` Jagan Teki
[not found] ` <CAMty3ZB9f_HrbJDjbAEPvf4UhcEhDm8hCaB8yq-yeVkFbtSTTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-18 14:43 ` Jernej Škrabec
2018-06-18 18:49 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615084542.slp3ma4krrj744do@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox