From: Daniel Mack <daniel@zonque.org>
To: jacek.anaszewski@gmail.com, robh+dt@kernel.org
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
Daniel Mack <daniel@zonque.org>
Subject: [PATCH 3/5] leds: lt3593: switch to gpiod interface
Date: Sun, 17 Jun 2018 13:49:27 +0200 [thread overview]
Message-ID: <20180617114929.719-3-daniel@zonque.org> (raw)
In-Reply-To: <20180617114929.719-1-daniel@zonque.org>
Clean up the code a bit and transition over to the gpiod based interface.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
drivers/leds/leds-lt3593.c | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c
index 1a3dc347db21..a096ee64cbbb 100644
--- a/drivers/leds/leds-lt3593.c
+++ b/drivers/leds/leds-lt3593.c
@@ -21,12 +21,13 @@
#include <linux/leds.h>
#include <linux/delay.h>
#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/slab.h>
#include <linux/module.h>
struct lt3593_led_data {
struct led_classdev cdev;
- unsigned gpio;
+ struct gpio_desc *gpiod;
};
static int lt3593_led_set(struct led_classdev *led_cdev,
@@ -46,25 +47,25 @@ static int lt3593_led_set(struct led_classdev *led_cdev,
*/
if (value == 0) {
- gpio_set_value_cansleep(led_dat->gpio, 0);
+ gpiod_set_value_cansleep(led_dat->gpiod, 0);
return 0;
}
pulses = 32 - (value * 32) / 255;
if (pulses == 0) {
- gpio_set_value_cansleep(led_dat->gpio, 0);
+ gpiod_set_value_cansleep(led_dat->gpiod, 0);
mdelay(1);
- gpio_set_value_cansleep(led_dat->gpio, 1);
+ gpiod_set_value_cansleep(led_dat->gpiod, 1);
return 0;
}
- gpio_set_value_cansleep(led_dat->gpio, 1);
+ gpiod_set_value_cansleep(led_dat->gpiod, 1);
while (pulses--) {
- gpio_set_value_cansleep(led_dat->gpio, 0);
+ gpiod_set_value_cansleep(led_dat->gpiod, 0);
udelay(1);
- gpio_set_value_cansleep(led_dat->gpio, 1);
+ gpiod_set_value_cansleep(led_dat->gpiod, 1);
udelay(1);
}
@@ -85,15 +86,8 @@ static struct lt3593_led_data *lt3593_led_probe_pdata(struct device *dev)
if (!led_data)
return ERR_PTR(-ENOMEM);
- if (!gpio_is_valid(template->gpio)) {
- dev_info(dev, "skipping unavailable LT3593 LED at gpio "
- "%d (%s)\n", template->gpio, template->name);
- return ERR_PTR(-EINVAL);
- }
-
led_data->cdev.name = template->name;
led_data->cdev.default_trigger = template->default_trigger;
- led_data->gpio = template->gpio;
led_data->cdev.brightness_set_blocking = lt3593_led_set;
state = (template->default_state == LEDS_GPIO_DEFSTATE_ON);
@@ -108,6 +102,10 @@ static struct lt3593_led_data *lt3593_led_probe_pdata(struct device *dev)
if (ret < 0)
return ERR_PTR(ret);
+ led_data->gpiod = gpio_to_desc(template->gpio);
+ if (!led_data->gpiod)
+ return ERR_PTR(-EPROBE_DEFER);
+
ret = devm_led_classdev_register(dev, &led_data->cdev);
if (ret < 0)
return ERR_PTR(ret);
--
2.17.1
next prev parent reply other threads:[~2018-06-17 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 11:49 [PATCH 1/5] dt-bindings: leds: Add bindings for lltc,lt3593 Daniel Mack
2018-06-17 11:49 ` [PATCH 2/5] leds: lt3593: merge functions and clean up code Daniel Mack
2018-06-17 11:49 ` Daniel Mack [this message]
2018-06-17 11:49 ` [PATCH 4/5] leds: lt3593: Add device tree probing glue Daniel Mack
2018-06-17 11:49 ` [PATCH 5/5] leds: lt3593: update email address Daniel Mack
2018-06-17 19:39 ` [PATCH 1/5] dt-bindings: leds: Add bindings for lltc,lt3593 Jacek Anaszewski
2018-06-17 19:52 ` Daniel Mack
2018-06-17 20:08 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180617114929.719-3-daniel@zonque.org \
--to=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).