From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org
Cc: Taniya Das <tdas@codeaurora.org>,
robh@kernel.org, Rajendra Nayak <rnayak@codeaurora.org>,
devicetree@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Amit Nischal <anischal@codeaurora.org>,
linux-kernel@vger.kernel.org,
David Brown <david.brown@linaro.org>,
Rohit Kumar <rohitkr@codeaurora.org>,
kbuild-all@01.org, Andy Gross <andy.gross@linaro.org>,
linux-soc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: Add lpass clock controller driver for SDM845
Date: Mon, 18 Jun 2018 17:40:11 +0300 [thread overview]
Message-ID: <20180618144011.v5uwk4lkiuynggl3@mwanda> (raw)
In-Reply-To: <1528961943-12506-3-git-send-email-tdas@codeaurora.org>
Hi Taniya,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Taniya-Das/Add-support-for-LPASS-clock-controller-for-SDM845/20180614-155144
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
smatch warnings:
drivers/clk/qcom/lpasscc-sdm845.c:197 lpass_clocks_sdm845_probe() warn: passing zero to 'PTR_ERR'
# https://github.com/0day-ci/linux/commit/035d2520712de752be68d10a37650b65b6aee154
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 035d2520712de752be68d10a37650b65b6aee154
vim +/PTR_ERR +197 drivers/clk/qcom/lpasscc-sdm845.c
035d2520 Taniya Das 2018-06-14 179
035d2520 Taniya Das 2018-06-14 180 static int lpass_clocks_sdm845_probe(struct platform_device *pdev,
035d2520 Taniya Das 2018-06-14 181 struct device_node *np,
035d2520 Taniya Das 2018-06-14 182 const struct qcom_cc_desc *desc)
035d2520 Taniya Das 2018-06-14 183 {
035d2520 Taniya Das 2018-06-14 184 struct regmap *regmap;
035d2520 Taniya Das 2018-06-14 185 struct resource res;
035d2520 Taniya Das 2018-06-14 186 void __iomem *base;
035d2520 Taniya Das 2018-06-14 187
035d2520 Taniya Das 2018-06-14 188 if (of_address_to_resource(np, 0, &res))
035d2520 Taniya Das 2018-06-14 189 return -ENOMEM;
035d2520 Taniya Das 2018-06-14 190
035d2520 Taniya Das 2018-06-14 191 base = devm_ioremap(&pdev->dev, res.start, resource_size(&res));
035d2520 Taniya Das 2018-06-14 192 if (IS_ERR(base))
035d2520 Taniya Das 2018-06-14 193 return -ENOMEM;
035d2520 Taniya Das 2018-06-14 194
035d2520 Taniya Das 2018-06-14 195 regmap = devm_regmap_init_mmio(&pdev->dev, base, desc->config);
035d2520 Taniya Das 2018-06-14 196 if (!regmap)
035d2520 Taniya Das 2018-06-14 @197 return PTR_ERR(regmap);
^^^^^^^^^^^^^^^
035d2520 Taniya Das 2018-06-14 198
035d2520 Taniya Das 2018-06-14 199 return qcom_cc_really_probe(pdev, desc, regmap);
035d2520 Taniya Das 2018-06-14 200 }
035d2520 Taniya Das 2018-06-14 201
next prev parent reply other threads:[~2018-06-18 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 7:39 [PATCH 0/2] Add support for LPASS clock controller for SDM845 Taniya Das
2018-06-14 7:39 ` [PATCH 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings Taniya Das
2018-06-26 19:53 ` Rob Herring
2018-06-14 7:39 ` [PATCH 2/2] clk: qcom: Add lpass clock controller driver for SDM845 Taniya Das
2018-06-14 10:38 ` kbuild test robot
2018-06-14 10:38 ` [RFC PATCH] clk: qcom: gcc_lpass_sway_clk can be static kbuild test robot
2018-06-18 14:40 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-11 17:00 [PATCH v4 0/2] Add support for LPASS clock controller for SDM845 Taniya Das
2018-09-11 17:00 ` [PATCH 2/2] clk: qcom: Add lpass clock controller driver " Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618144011.v5uwk4lkiuynggl3@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andy.gross@linaro.org \
--cc=anischal@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox