* [PATCH v2 1/2] dt-bindings: rng: Add new compatible qcom,prng-v2
[not found] <20180619095430.26358-1-vkoul@kernel.org>
@ 2018-06-19 9:54 ` Vinod Koul
2018-06-25 19:06 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2018-06-19 9:54 UTC (permalink / raw)
To: linux-crypto, linux-kernel
Cc: Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
linux-arm-msm, Stephen Boyd, vinod.koul, Vinod Koul, Rob Herring,
devicetree
Later qcom chips support v2 of the prng, so add new compatible
qcom,prng-v2 for this.
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Documentation/devicetree/bindings/rng/qcom,prng.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rng/qcom,prng.txt b/Documentation/devicetree/bindings/rng/qcom,prng.txt
index 8e5853c2879b..03fd218bd21a 100644
--- a/Documentation/devicetree/bindings/rng/qcom,prng.txt
+++ b/Documentation/devicetree/bindings/rng/qcom,prng.txt
@@ -2,7 +2,8 @@ Qualcomm MSM pseudo random number generator.
Required properties:
-- compatible : should be "qcom,prng"
+- compatible : should be "qcom,prng" for 8916 etc
+ : should be "qcom,prng-v2" for 8996 and later
- reg : specifies base physical address and size of the registers map
- clocks : phandle to clock-controller plus clock-specifier pair
- clock-names : "core" clocks all registers, FIFO and circuits in PRNG IP block
--
2.14.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: rng: Add new compatible qcom,prng-v2
2018-06-19 9:54 ` [PATCH v2 1/2] dt-bindings: rng: Add new compatible qcom,prng-v2 Vinod Koul
@ 2018-06-25 19:06 ` Rob Herring
2018-06-26 15:27 ` Vinod
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2018-06-25 19:06 UTC (permalink / raw)
To: Vinod Koul
Cc: linux-crypto, linux-kernel, Matt Mackall, Herbert Xu,
Arnd Bergmann, Greg Kroah-Hartman, linux-arm-msm, Stephen Boyd,
Vinod Koul, devicetree
On Tue, Jun 19, 2018 at 03:24:29PM +0530, Vinod Koul wrote:
> Later qcom chips support v2 of the prng, so add new compatible
> qcom,prng-v2 for this.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Documentation/devicetree/bindings/rng/qcom,prng.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rng/qcom,prng.txt b/Documentation/devicetree/bindings/rng/qcom,prng.txt
> index 8e5853c2879b..03fd218bd21a 100644
> --- a/Documentation/devicetree/bindings/rng/qcom,prng.txt
> +++ b/Documentation/devicetree/bindings/rng/qcom,prng.txt
> @@ -2,7 +2,8 @@ Qualcomm MSM pseudo random number generator.
>
> Required properties:
>
> -- compatible : should be "qcom,prng"
> +- compatible : should be "qcom,prng" for 8916 etc
> + : should be "qcom,prng-v2" for 8996 and later
Either use SoC specific compatibles or convince me 'v2' is a meaningful
and specific enough version. Some other QC IP has x.y.z versioning for
example.
> - reg : specifies base physical address and size of the registers map
> - clocks : phandle to clock-controller plus clock-specifier pair
> - clock-names : "core" clocks all registers, FIFO and circuits in PRNG IP block
> --
> 2.14.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: rng: Add new compatible qcom,prng-v2
2018-06-25 19:06 ` Rob Herring
@ 2018-06-26 15:27 ` Vinod
0 siblings, 0 replies; 3+ messages in thread
From: Vinod @ 2018-06-26 15:27 UTC (permalink / raw)
To: Rob Herring
Cc: linux-crypto, linux-kernel, Matt Mackall, Herbert Xu,
Arnd Bergmann, Greg Kroah-Hartman, linux-arm-msm, Stephen Boyd,
devicetree
On 25-06-18, 13:06, Rob Herring wrote:
> On Tue, Jun 19, 2018 at 03:24:29PM +0530, Vinod Koul wrote:
> > Later qcom chips support v2 of the prng, so add new compatible
> > qcom,prng-v2 for this.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Documentation/devicetree/bindings/rng/qcom,prng.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rng/qcom,prng.txt b/Documentation/devicetree/bindings/rng/qcom,prng.txt
> > index 8e5853c2879b..03fd218bd21a 100644
> > --- a/Documentation/devicetree/bindings/rng/qcom,prng.txt
> > +++ b/Documentation/devicetree/bindings/rng/qcom,prng.txt
> > @@ -2,7 +2,8 @@ Qualcomm MSM pseudo random number generator.
> >
> > Required properties:
> >
> > -- compatible : should be "qcom,prng"
> > +- compatible : should be "qcom,prng" for 8916 etc
> > + : should be "qcom,prng-v2" for 8996 and later
>
> Either use SoC specific compatibles or convince me 'v2' is a meaningful
> and specific enough version. Some other QC IP has x.y.z versioning for
> example.
The specs says QC RNG V2 :)
Said that Stephen suggested to make it qcom,prng-ee to point out that we
are pointing to an execution environment in the IP, so will do that
instead unless you have better idea
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-26 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180619095430.26358-1-vkoul@kernel.org>
2018-06-19 9:54 ` [PATCH v2 1/2] dt-bindings: rng: Add new compatible qcom,prng-v2 Vinod Koul
2018-06-25 19:06 ` Rob Herring
2018-06-26 15:27 ` Vinod
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).