* [PATCH v2] arm64: dts: renesas: salvator-common: Add HSCIF1 device support
@ 2018-06-19 17:14 Geert Uytterhoeven
2018-06-20 8:54 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-06-19 17:14 UTC (permalink / raw)
To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland
Cc: Wolfram Sang, Laurent Pinchart, Ulrich Hecht, linux-renesas-soc,
devicetree, Hiromitsu Yamasaki, Takeshi Kihara,
Geert Uytterhoeven
From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
This patch adds pin control for HSCIF1, and supports connection with
Debug Serial-1 (CN26) on Salvator boards.
SCIF1 and HSCIF1 are sharing the pins connected to Debug Serial-1 (CN26)
on Salvator boards, and it is necessary to ensure that either SCIF1 or
HSCIF1 is enabled, not both.
As for the default of this DeviceTree, SCIF1 is connected.
Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[geert: Add missing "uart-has-rtscts"]
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Drop RFC state,
- Reword.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index d9de075c91df3a06..82623b8f7c2657d8 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -353,6 +353,15 @@
clock-frequency = <32768>;
};
+&hscif1 {
+ pinctrl-0 = <&hscif1_pins>;
+ pinctrl-names = "default";
+
+ uart-has-rtscts;
+ /* Please only enable hscif1 or scif1 */
+ /* status = "okay"; */
+};
+
&hsusb {
dr_mode = "otg";
status = "okay";
@@ -558,6 +567,11 @@
function = "du";
};
+ hscif1_pins: hscif1 {
+ groups = "hscif1_data_a", "hscif1_ctrl_a";
+ function = "hscif1";
+ };
+
i2c2_pins: i2c2 {
groups = "i2c2_a";
function = "i2c2";
@@ -728,6 +742,7 @@
pinctrl-names = "default";
uart-has-rtscts;
+ /* Please only enable hscif1 or scif1 */
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: renesas: salvator-common: Add HSCIF1 device support
2018-06-19 17:14 [PATCH v2] arm64: dts: renesas: salvator-common: Add HSCIF1 device support Geert Uytterhoeven
@ 2018-06-20 8:54 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2018-06-20 8:54 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Rob Herring, Mark Rutland, Wolfram Sang,
Laurent Pinchart, Ulrich Hecht, linux-renesas-soc, devicetree,
Hiromitsu Yamasaki, Takeshi Kihara
On Tue, Jun 19, 2018 at 07:14:01PM +0200, Geert Uytterhoeven wrote:
> From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
>
> This patch adds pin control for HSCIF1, and supports connection with
> Debug Serial-1 (CN26) on Salvator boards.
>
> SCIF1 and HSCIF1 are sharing the pins connected to Debug Serial-1 (CN26)
> on Salvator boards, and it is necessary to ensure that either SCIF1 or
> HSCIF1 is enabled, not both.
>
> As for the default of this DeviceTree, SCIF1 is connected.
>
> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [geert: Add missing "uart-has-rtscts"]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Drop RFC state,
> - Reword.
Thanks Geert,
applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-20 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-19 17:14 [PATCH v2] arm64: dts: renesas: salvator-common: Add HSCIF1 device support Geert Uytterhoeven
2018-06-20 8:54 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).