From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: exynos: Remove unneeded DSI and DECON address/size cells in Exynos5433
Date: Wed, 20 Jun 2018 21:34:07 +0200 [thread overview]
Message-ID: <20180620193407.gk5e5ecolo5bel3c@kozik-lap> (raw)
In-Reply-To: <CAJKOXPeCT3CkqqNowEZaeTw7goJd6=Nbd2S61QzTFW-nGr5AKg@mail.gmail.com>
On Tue, Jun 19, 2018 at 09:59:04AM +0200, Krzysztof Kozlowski wrote:
> On 19 June 2018 at 09:26, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> > Hi Krzysztof,
> >
> > On 2018-06-18 19:42, Krzysztof Kozlowski wrote:
> >> The decon, decon_tv and dsi nodes have only one child port so
> >> address/size mappings are not necessary. This fixes DTC warnings like:
> >>
> >> Warning (graph_child_address): /soc/decon@13800000/ports:
> >> graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > Works fine with current Exynos DRM Decon/MIC/DSI drivers.
> >
> > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> Thanks for review and testing!
I have second thoughs whether this patch is correct. AFAIU, the drivers
get the remote endpoints by reg==0 (for example the
of_graph_get_remote_node() in exynos_dsi_parse_dt()). If the port shall
be ignored, then reg==-1 should be passed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2018-06-20 19:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 17:42 [PATCH 1/2] arm64: dts: exynos: Remove leading 0x from unit addresses in Exynos5433 Krzysztof Kozlowski
2018-06-18 17:42 ` [PATCH 2/2] arm64: dts: exynos: Remove unneeded DSI and DECON address/size cells " Krzysztof Kozlowski
2018-06-18 18:37 ` Krzysztof Kozlowski
2018-06-19 7:25 ` Andrzej Hajda
2018-06-19 7:26 ` Marek Szyprowski
2018-06-19 7:59 ` Krzysztof Kozlowski
2018-06-20 19:34 ` Krzysztof Kozlowski [this message]
2018-06-21 5:59 ` Andrzej Hajda
2018-06-21 7:21 ` Krzysztof Kozlowski
2018-06-18 17:57 ` [PATCH 1/2] arm64: dts: exynos: Remove leading 0x from unit addresses " Joe Perches
2018-06-18 19:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620193407.gk5e5ecolo5bel3c@kozik-lap \
--to=krzk@kernel.org \
--cc=a.hajda@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox