* [PATCH v2] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
@ 2018-06-20 19:42 Nick Dyer
2018-06-20 20:20 ` [PATCH v3] " Nick Dyer
0 siblings, 1 reply; 7+ messages in thread
From: Nick Dyer @ 2018-06-20 19:42 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, devicetree,
Fabio Estevam, Andrey Smirnov, Nikita Yushchenko, Chris Healy,
Lucas Stach, Nick Dyer
The pinctrl settings were incorrect for the touchscreen interrupt line, causing
an interrupt storm. This change has been tested with both the atmel_mxt_ts and
RMI4 drivers on the RDU1 units.
[v2: Use hex, only alter IRQ line config]
Signed-off-by: Nick Dyer <nick@shmanahar.org>
---
arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index df9eca94d812..8a878687197b 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -770,7 +770,7 @@
pinctrl_ts: tsgrp {
fsl,pins = <
- MX51_PAD_CSI1_D8__GPIO3_12 0x85
+ MX51_PAD_CSI1_D8__GPIO3_12 0x04
MX51_PAD_CSI1_D9__GPIO3_13 0x85
>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v3] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
2018-06-20 19:42 [PATCH v2] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl Nick Dyer
@ 2018-06-20 20:20 ` Nick Dyer
2018-06-20 20:31 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Nick Dyer @ 2018-06-20 20:20 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, devicetree,
Fabio Estevam, Andrey Smirnov, Nikita Yushchenko, Chris Healy,
Lucas Stach, Nick Dyer, stable
The pinctrl settings were incorrect for the touchscreen interrupt line, causing
an interrupt storm. This change has been tested with both the atmel_mxt_ts and
RMI4 drivers on the RDU1 units.
The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
from the old vendor kernel.
Signed-off-by: Nick Dyer <nick@shmanahar.org>
Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
Cc: <stable@vger.kernel.org> # 4.15+
---
Changes in v3:
- Update commit message to add source of 0x4 value, fixes tag and CC stable
Changes in v2:
- Use hex, only alter IRQ line config
arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index df9eca94d812..8a878687197b 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -770,7 +770,7 @@
pinctrl_ts: tsgrp {
fsl,pins = <
- MX51_PAD_CSI1_D8__GPIO3_12 0x85
+ MX51_PAD_CSI1_D8__GPIO3_12 0x04
MX51_PAD_CSI1_D9__GPIO3_13 0x85
>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
2018-06-20 20:20 ` [PATCH v3] " Nick Dyer
@ 2018-06-20 20:31 ` Fabio Estevam
2018-06-20 20:35 ` [PATCH v4] " Nick Dyer
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2018-06-20 20:31 UTC (permalink / raw)
To: Nick Dyer
Cc: Shawn Guo, Sascha Hauer,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Andrey Smirnov, Nikita Yushchenko, Chris Healy, Lucas Stach,
stable
On Wed, Jun 20, 2018 at 5:20 PM, Nick Dyer <nick@shmanahar.org> wrote:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
>
> The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
> from the old vendor kernel.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
> Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
> Cc: <stable@vger.kernel.org> # 4.15+
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v4] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
2018-06-20 20:31 ` Fabio Estevam
@ 2018-06-20 20:35 ` Nick Dyer
2018-06-21 4:22 ` Chris Healy
0 siblings, 1 reply; 7+ messages in thread
From: Nick Dyer @ 2018-06-20 20:35 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, devicetree,
Fabio Estevam, Andrey Smirnov, Nikita Yushchenko, Chris Healy,
Lucas Stach, Nick Dyer, stable
The pinctrl settings were incorrect for the touchscreen interrupt line, causing
an interrupt storm. This change has been tested with both the atmel_mxt_ts and
RMI4 drivers on the RDU1 units.
The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
from the old vendor kernel.
Signed-off-by: Nick Dyer <nick@shmanahar.org>
Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
Cc: <stable@vger.kernel.org> # 4.15+
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes in v4:
- Add reviewed by Fabio
Changes in v3:
- Update commit message to add source of 0x4 value, fixes tag and CC stable
Changes in v2:
- Use hex, only alter IRQ line config
arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index df9eca94d812..8a878687197b 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -770,7 +770,7 @@
pinctrl_ts: tsgrp {
fsl,pins = <
- MX51_PAD_CSI1_D8__GPIO3_12 0x85
+ MX51_PAD_CSI1_D8__GPIO3_12 0x04
MX51_PAD_CSI1_D9__GPIO3_13 0x85
>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v4] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
2018-06-20 20:35 ` [PATCH v4] " Nick Dyer
@ 2018-06-21 4:22 ` Chris Healy
2018-06-21 18:10 ` [PATCH v5] " Nick Dyer
0 siblings, 1 reply; 7+ messages in thread
From: Chris Healy @ 2018-06-21 4:22 UTC (permalink / raw)
To: Nick Dyer
Cc: Shawn Guo, Sascha Hauer, linux ARM, linux-kernel, devicetree,
Fabio Estevam, Andrey Smirnov, Nikita Yushchenko, Lucas Stach,
stable
On Wed, Jun 20, 2018 at 1:35 PM, Nick Dyer <nick@shmanahar.org> wrote:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
>
> The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
> from the old vendor kernel.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
> Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
> Cc: <stable@vger.kernel.org> # 4.15+
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes in v4:
> - Add reviewed by Fabio
> Changes in v3:
> - Update commit message to add source of 0x4 value, fixes tag and CC stable
> Changes in v2:
> - Use hex, only alter IRQ line config
Tested on an RDU1 with Synaptics touchscreen successfully. No
interrupt store any longer...
Tested-by: Chris Healy <cphealy@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v5] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
2018-06-21 4:22 ` Chris Healy
@ 2018-06-21 18:10 ` Nick Dyer
2018-07-01 3:20 ` Shawn Guo
0 siblings, 1 reply; 7+ messages in thread
From: Nick Dyer @ 2018-06-21 18:10 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, devicetree,
Fabio Estevam, Andrey Smirnov, Nikita Yushchenko, Chris Healy,
Lucas Stach, Nick Dyer, stable
The pinctrl settings were incorrect for the touchscreen interrupt line, causing
an interrupt storm. This change has been tested with both the atmel_mxt_ts and
RMI4 drivers on the RDU1 units.
The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
from the old vendor kernel.
Signed-off-by: Nick Dyer <nick@shmanahar.org>
Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
Cc: <stable@vger.kernel.org> # 4.15+
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Tested-by: Chris Healy <cphealy@gmail.com>
---
Changes in v5:
- Add tested by Chris Healy
Changes in v4:
- Add reviewed by Fabio
Changes in v3:
- Update commit message to add source of 0x4 value, fixes tag and CC stable
Changes in v2:
- Use hex, only alter IRQ line config
arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index df9eca94d812..8a878687197b 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -770,7 +770,7 @@
pinctrl_ts: tsgrp {
fsl,pins = <
- MX51_PAD_CSI1_D8__GPIO3_12 0x85
+ MX51_PAD_CSI1_D8__GPIO3_12 0x04
MX51_PAD_CSI1_D9__GPIO3_13 0x85
>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v5] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
2018-06-21 18:10 ` [PATCH v5] " Nick Dyer
@ 2018-07-01 3:20 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2018-07-01 3:20 UTC (permalink / raw)
To: Nick Dyer
Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, devicetree,
Fabio Estevam, Andrey Smirnov, Nikita Yushchenko, Chris Healy,
Lucas Stach, stable
On Thu, Jun 21, 2018 at 07:10:00PM +0100, Nick Dyer wrote:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
>
> The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
> from the old vendor kernel.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
> Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
> Cc: <stable@vger.kernel.org> # 4.15+
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Tested-by: Chris Healy <cphealy@gmail.com>
Applied, thanks.
> ---
> Changes in v5:
> - Add tested by Chris Healy
> Changes in v4:
> - Add reviewed by Fabio
You do not have to send new version just for collecting review and test
tags. I will do that when applying.
Shawn
> Changes in v3:
> - Update commit message to add source of 0x4 value, fixes tag and CC stable
> Changes in v2:
> - Use hex, only alter IRQ line config
>
> arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index df9eca94d812..8a878687197b 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -770,7 +770,7 @@
>
> pinctrl_ts: tsgrp {
> fsl,pins = <
> - MX51_PAD_CSI1_D8__GPIO3_12 0x85
> + MX51_PAD_CSI1_D8__GPIO3_12 0x04
> MX51_PAD_CSI1_D9__GPIO3_13 0x85
> >;
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-07-01 3:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-20 19:42 [PATCH v2] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl Nick Dyer
2018-06-20 20:20 ` [PATCH v3] " Nick Dyer
2018-06-20 20:31 ` Fabio Estevam
2018-06-20 20:35 ` [PATCH v4] " Nick Dyer
2018-06-21 4:22 ` Chris Healy
2018-06-21 18:10 ` [PATCH v5] " Nick Dyer
2018-07-01 3:20 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).