From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vinod.koul@linaro.org>
Cc: linux-input@vger.kernel.org, linux-pm@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH 5/5] input: pm8941-pwrkey: Add resin entry
Date: Fri, 22 Jun 2018 14:00:12 -0700 [thread overview]
Message-ID: <20180622210012.GH3402@tuxbook-pro> (raw)
In-Reply-To: <20180618143548.29900-6-vkoul@kernel.org>
On Mon 18 Jun 07:35 PDT 2018, Vinod Koul wrote:
> Since handling is abstracted in this driver, we need to add resin entry
> in id table along with pwrkey_data.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/input/misc/pm8941-pwrkey.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/input/misc/pm8941-pwrkey.c b/drivers/input/misc/pm8941-pwrkey.c
> index aedb6ea2b50a..913405404a92 100644
> --- a/drivers/input/misc/pm8941-pwrkey.c
> +++ b/drivers/input/misc/pm8941-pwrkey.c
> @@ -29,6 +29,7 @@
>
> #define PON_RT_STS 0x10
> #define PON_KPDPWR_N_SET BIT(0)
> +#define PON_RESIN_N_SET BIT(1)
>
> #define PON_PS_HOLD_RST_CTL 0x5a
> #define PON_PS_HOLD_RST_CTL2 0x5b
> @@ -39,6 +40,7 @@
>
> #define PON_PULL_CTL 0x70
> #define PON_KPDPWR_PULL_UP BIT(1)
> +#define PON_RESIN_PULL_UP BIT(0)
>
> #define PON_DBC_CTL 0x71
> #define PON_DBC_DELAY_MASK 0x7
> @@ -307,8 +309,14 @@ static const struct pm8941_data pwrkey_data = {
> .status_bit = PON_KPDPWR_N_SET,
> };
>
> +static const struct pm8941_data resin_data = {
> + .pull_up_bit = PON_RESIN_PULL_UP,
> + .status_bit = PON_RESIN_N_SET,
> +};
> +
> static const struct of_device_id pm8941_pwr_key_id_table[] = {
> { .compatible = "qcom,pm8941-pwrkey", .data = &pwrkey_data },
> + { .compatible = "qcom,pm8941-resin", .data = &resin_data },
> { }
> };
> MODULE_DEVICE_TABLE(of, pm8941_pwr_key_id_table);
> --
> 2.14.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-22 21:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 14:35 [PATCH 0/5]: input: pm8941-pwrkey: Add support for reboot reason Vinod Koul
2018-06-18 14:35 ` [PATCH 1/5] dt-bindings: power: reset: Add qcom pon binding Vinod Koul
2018-06-22 20:58 ` Bjorn Andersson
2018-06-23 4:29 ` Vinod
2018-06-18 14:35 ` [PATCH 2/5] power: reset: qcom-pon: Add Qcom PON driver Vinod Koul
2018-06-18 14:35 ` [PATCH 3/5] dt-bindings: Input: Add additional property to qcom pwrkey Vinod Koul
2018-06-22 20:59 ` Bjorn Andersson
2018-06-18 14:35 ` [PATCH 4/5] input: pm8941-pwrkey: Abstract register offsets and event code Vinod Koul
2018-06-22 18:52 ` Dmitry Torokhov
2018-06-23 4:32 ` Vinod
2018-06-22 21:10 ` Bjorn Andersson
2018-06-23 4:34 ` Vinod
2018-06-18 14:35 ` [PATCH 5/5] input: pm8941-pwrkey: Add resin entry Vinod Koul
2018-06-22 21:00 ` Bjorn Andersson [this message]
2018-06-22 18:53 ` [PATCH 0/5]: input: pm8941-pwrkey: Add support for reboot reason Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622210012.GH3402@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox