Re: [PATCH 1/5] dt-bindings: power: reset: Add qcom pon binding

[Vinod <vkoul@kernel.org>]

On 22-06-18, 13:58, Bjorn Andersson wrote:
> On Mon 18 Jun 07:35 PDT 2018, Vinod Koul wrote:
> 
> > +The Power On driver for Qualcomm PM8xxx is MFD supporting pwrkey and
> > +resin along with the Android reboot-mode.
> > +
> > +This DT node has pwrkey and resin as sub nodes.
> > +
> > +Required Properties:
> > +-compatible: "qcom,pm8916-pon"
> > +-reg: Specifies the physical address of the pon register
> > +
> > +Optional property:
> 
> Better call these "Optional subnodes".

Yes will do..

> > +-prwrkey: Specifies the subnode pwrkey and should follow the
> > + qcom,pm8xxx-pwrkey.txt description.
> > +-resin: Specifies the subnode resin and should follow the
> > + qcom,pm8xxx-pwrkey.txt description.
> > +
> > +The rest of the properties should follow the generic reboot-mode description
> > +found in reboot-mode.txt
> > +
> > +Example:
> > +
> > +	pon@800 {
> > +		compatible = "qcom,pm8916-pon";
> > +
> > +		reg = <0x800>;
> > +		mode-bootloader = <0x2>;
> > +		mode-recovery = <0x1>;
> > +
> > +		pwrkey {
> > +			compatible = "qcom,pm8941-pwrkey";
> > +			reg = <0x800>;
> 
> Didn't we conclude that you could drop the "reg" of the children?

Sloppy me, fixed the code & DTS but not the binding, thanks for pointing

> Apart from that this looks good.

Thanks :)

-- 
~Vinod