* [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT
@ 2018-06-23 18:54 Andreas Klinger
2018-06-24 13:10 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Klinger @ 2018-06-23 18:54 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, robh+dt, mark.rutland, mchehab,
davem, gregkh, akpm, linus.walleij, rdunlap, devicetree,
linux-iio, linux-kernel
add data-ready-delay-ns property for hx711 ADC
this is the delay after rising PD_SCK until DOUT is read and assumed to be
ready
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
index b3629405f568..8c9bcaa4d750 100644
--- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
+++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
@@ -8,11 +8,18 @@ Required properties:
See Documentation/devicetree/bindings/gpio/gpio.txt
- avdd-supply: Definition of the regulator used as analog supply
+Optional properties:
+ - data-ready-delay-ns: additional delay in nanoseconds between rising of
+ PD_SCK until DOUT is ready
+ should be less then maximum PD_SCK high time which
+ is 50000 in the datasheet
+
Example:
-weight@0 {
+weight {
compatible = "avia,hx711";
sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
avdd-suppy = <&avdd>;
+ data-ready-delay-ns = <1000>;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT
2018-06-23 18:54 [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT Andreas Klinger
@ 2018-06-24 13:10 ` Jonathan Cameron
2018-06-24 13:28 ` Andreas Klinger
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2018-06-24 13:10 UTC (permalink / raw)
To: Andreas Klinger
Cc: knaack.h, lars, pmeerw, robh+dt, mark.rutland, mchehab, davem,
gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio,
linux-kernel
On Sat, 23 Jun 2018 20:54:21 +0200
Andreas Klinger <ak@it-klinger.de> wrote:
> add data-ready-delay-ns property for hx711 ADC
> this is the delay after rising PD_SCK until DOUT is read and assumed to be
> ready
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
One unconnected change. I'm not sure it's wrong as such but it should not
be in this patch.
> ---
> Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> index b3629405f568..8c9bcaa4d750 100644
> --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> @@ -8,11 +8,18 @@ Required properties:
> See Documentation/devicetree/bindings/gpio/gpio.txt
> - avdd-supply: Definition of the regulator used as analog supply
>
> +Optional properties:
> + - data-ready-delay-ns: additional delay in nanoseconds between rising of
> + PD_SCK until DOUT is ready
> + should be less then maximum PD_SCK high time which
> + is 50000 in the datasheet
> +
> Example:
> -weight@0 {
> +weight {
Change has nothing to do with this patch...
> compatible = "avia,hx711";
> sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
> avdd-suppy = <&avdd>;
> + data-ready-delay-ns = <1000>;
> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT
2018-06-24 13:10 ` Jonathan Cameron
@ 2018-06-24 13:28 ` Andreas Klinger
2018-06-24 13:48 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Klinger @ 2018-06-24 13:28 UTC (permalink / raw)
To: Jonathan Cameron
Cc: knaack.h, lars, pmeerw, robh+dt, mark.rutland, mchehab, davem,
gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio,
linux-kernel
Hi Jonathan,
Jonathan Cameron <jic23@kernel.org> schrieb am Sun, 24. Jun 14:10:
> On Sat, 23 Jun 2018 20:54:21 +0200
> Andreas Klinger <ak@it-klinger.de> wrote:
>
> > add data-ready-delay-ns property for hx711 ADC
> > this is the delay after rising PD_SCK until DOUT is read and assumed to be
> > ready
> >
> > Signed-off-by: Andreas Klinger <ak@it-klinger.de>
>
> One unconnected change. I'm not sure it's wrong as such but it should not
> be in this patch.
>
> > ---
> > Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > index b3629405f568..8c9bcaa4d750 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > @@ -8,11 +8,18 @@ Required properties:
> > See Documentation/devicetree/bindings/gpio/gpio.txt
> > - avdd-supply: Definition of the regulator used as analog supply
> >
> > +Optional properties:
> > + - data-ready-delay-ns: additional delay in nanoseconds between rising of
> > + PD_SCK until DOUT is ready
> > + should be less then maximum PD_SCK high time which
> > + is 50000 in the datasheet
> > +
> > Example:
> > -weight@0 {
> > +weight {
The device tree compiler (dtc) gives a warning if there is no reg = <...>
setting. That's why i changed it to be without @0.
Should i create an individual patch for this change in this series or
create another patch which is unrelated to this series?
Andreas
>
> Change has nothing to do with this patch...
>
> > compatible = "avia,hx711";
> > sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> > dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
> > avdd-suppy = <&avdd>;
> > + data-ready-delay-ns = <1000>;
> > };
> >
>
--
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT
2018-06-24 13:28 ` Andreas Klinger
@ 2018-06-24 13:48 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2018-06-24 13:48 UTC (permalink / raw)
To: Andreas Klinger
Cc: knaack.h, lars, pmeerw, robh+dt, mark.rutland, mchehab, davem,
gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio,
linux-kernel
On Sun, 24 Jun 2018 15:28:59 +0200
Andreas Klinger <ak@it-klinger.de> wrote:
> Hi Jonathan,
>
> Jonathan Cameron <jic23@kernel.org> schrieb am Sun, 24. Jun 14:10:
> > On Sat, 23 Jun 2018 20:54:21 +0200
> > Andreas Klinger <ak@it-klinger.de> wrote:
> >
> > > add data-ready-delay-ns property for hx711 ADC
> > > this is the delay after rising PD_SCK until DOUT is read and assumed to be
> > > ready
> > >
> > > Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> >
> > One unconnected change. I'm not sure it's wrong as such but it should not
> > be in this patch.
> >
> > > ---
> > > Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 9 ++++++++-
> > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > > index b3629405f568..8c9bcaa4d750 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > > @@ -8,11 +8,18 @@ Required properties:
> > > See Documentation/devicetree/bindings/gpio/gpio.txt
> > > - avdd-supply: Definition of the regulator used as analog supply
> > >
> > > +Optional properties:
> > > + - data-ready-delay-ns: additional delay in nanoseconds between rising of
> > > + PD_SCK until DOUT is ready
> > > + should be less then maximum PD_SCK high time which
> > > + is 50000 in the datasheet
> > > +
> > > Example:
> > > -weight@0 {
> > > +weight {
>
> The device tree compiler (dtc) gives a warning if there is no reg = <...>
> setting. That's why i changed it to be without @0.
>
> Should i create an individual patch for this change in this series or
> create another patch which is unrelated to this series?
Either is fine by me. It's such a trivial change that it really doesn't
matter.
Jonathan
>
> Andreas
>
> >
> > Change has nothing to do with this patch...
> >
> > > compatible = "avia,hx711";
> > > sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> > > dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
> > > avdd-suppy = <&avdd>;
> > > + data-ready-delay-ns = <1000>;
> > > };
> > >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-24 13:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-23 18:54 [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT Andreas Klinger
2018-06-24 13:10 ` Jonathan Cameron
2018-06-24 13:28 ` Andreas Klinger
2018-06-24 13:48 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).