From: Jonathan Cameron <jic23@kernel.org>
To: Andreas Klinger <ak@it-klinger.de>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org,
davem@davemloft.net, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, linus.walleij@linaro.org,
rdunlap@infradead.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT
Date: Sun, 24 Jun 2018 14:10:48 +0100 [thread overview]
Message-ID: <20180624141048.7628eaac@archlinux> (raw)
In-Reply-To: <20180623185420.GA17842@arbeit>
On Sat, 23 Jun 2018 20:54:21 +0200
Andreas Klinger <ak@it-klinger.de> wrote:
> add data-ready-delay-ns property for hx711 ADC
> this is the delay after rising PD_SCK until DOUT is read and assumed to be
> ready
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
One unconnected change. I'm not sure it's wrong as such but it should not
be in this patch.
> ---
> Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> index b3629405f568..8c9bcaa4d750 100644
> --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> @@ -8,11 +8,18 @@ Required properties:
> See Documentation/devicetree/bindings/gpio/gpio.txt
> - avdd-supply: Definition of the regulator used as analog supply
>
> +Optional properties:
> + - data-ready-delay-ns: additional delay in nanoseconds between rising of
> + PD_SCK until DOUT is ready
> + should be less then maximum PD_SCK high time which
> + is 50000 in the datasheet
> +
> Example:
> -weight@0 {
> +weight {
Change has nothing to do with this patch...
> compatible = "avia,hx711";
> sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
> avdd-suppy = <&avdd>;
> + data-ready-delay-ns = <1000>;
> };
>
next prev parent reply other threads:[~2018-06-24 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 18:54 [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT Andreas Klinger
2018-06-24 13:10 ` Jonathan Cameron [this message]
2018-06-24 13:28 ` Andreas Klinger
2018-06-24 13:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180624141048.7628eaac@archlinux \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).