From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT Date: Sun, 24 Jun 2018 14:10:48 +0100 Message-ID: <20180624141048.7628eaac@archlinux> References: <20180623185420.GA17842@arbeit> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180623185420.GA17842@arbeit> Sender: linux-kernel-owner@vger.kernel.org To: Andreas Klinger Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org, davem@davemloft.net, gregkh@linuxfoundation.org, akpm@linux-foundation.org, linus.walleij@linaro.org, rdunlap@infradead.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Sat, 23 Jun 2018 20:54:21 +0200 Andreas Klinger wrote: > add data-ready-delay-ns property for hx711 ADC > this is the delay after rising PD_SCK until DOUT is read and assumed to be > ready > > Signed-off-by: Andreas Klinger One unconnected change. I'm not sure it's wrong as such but it should not be in this patch. > --- > Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > index b3629405f568..8c9bcaa4d750 100644 > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > @@ -8,11 +8,18 @@ Required properties: > See Documentation/devicetree/bindings/gpio/gpio.txt > - avdd-supply: Definition of the regulator used as analog supply > > +Optional properties: > + - data-ready-delay-ns: additional delay in nanoseconds between rising of > + PD_SCK until DOUT is ready > + should be less then maximum PD_SCK high time which > + is 50000 in the datasheet > + > Example: > -weight@0 { > +weight { Change has nothing to do with this patch... > compatible = "avia,hx711"; > sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>; > dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>; > avdd-suppy = <&avdd>; > + data-ready-delay-ns = <1000>; > }; >