From: Vinod <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-input@vger.kernel.org, linux-pm@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 4/5] input: pm8941-pwrkey: Abstract register offsets and event code
Date: Mon, 25 Jun 2018 11:44:17 +0530 [thread overview]
Message-ID: <20180625061417.GB2404@vkoul-mobl> (raw)
In-Reply-To: <20180625061152.GB1376@tuxbook-pro>
On 24-06-18, 23:11, Bjorn Andersson wrote:
> > struct pm8941_pwrkey {
> > struct device *dev;
> > @@ -52,6 +57,9 @@ struct pm8941_pwrkey {
> >
> > unsigned int revision;
> > struct notifier_block reboot_notifier;
> > +
> > + unsigned int code;
>
> I still would like this to be a u32, as you pass it by reference to a
> function taking a u32.
somehow missed this one, will update and send v3 with your ACK
> Apart from that, this looks good and you have my:
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
--
~Vinod
next prev parent reply other threads:[~2018-06-25 6:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 5:09 [PATCH v2 0/5] input: pm8941-pwrkey: Add support for reboot reason Vinod Koul
2018-06-25 5:09 ` [PATCH v2 1/5] dt-bindings: power: reset: Add qcom pon binding Vinod Koul
2018-06-25 6:08 ` Bjorn Andersson
2018-06-25 5:09 ` [PATCH v2 2/5] power: reset: qcom-pon: Add Qcom PON driver Vinod Koul
2018-06-25 5:09 ` [PATCH v2 3/5] dt-bindings: Input: Add additional property to qcom pwrkey Vinod Koul
2018-06-25 5:09 ` [PATCH v2 4/5] input: pm8941-pwrkey: Abstract register offsets and event code Vinod Koul
2018-06-25 6:11 ` Bjorn Andersson
2018-06-25 6:14 ` Vinod [this message]
2018-06-25 5:09 ` [PATCH v2 5/5] input: pm8941-pwrkey: Add resin entry Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625061417.GB2404@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).