public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Todd Poynor <toddpoynor@gmail.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, kernel-team@android.com,
	Todd Poynor <toddpoynor@google.com>
Subject: Re: [PATCH v2] drivers: base: initcall_debug logs for driver probe times
Date: Mon, 25 Jun 2018 09:20:55 -0600	[thread overview]
Message-ID: <20180625152055.GA23270@rob-hp-laptop> (raw)
In-Reply-To: <20180621003556.65578-1-toddpoynor@gmail.com>

On Wed, Jun 20, 2018 at 05:35:56PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@google.com>
> 
> Add initcall_debug logs for each driver device probe call, for example:
> 
>    probe of a3800000.ramoops returned 1 after 3007 usecs
> 
> This replaces the previous code added to report times for deferred
> probes.  It also reports OF platform bus device creates that were
> formerly lumped together in a single entry for function
> of_platform_default_populate_init, as well as helping to annotate other
> initcalls that involve device probing.
> 
> Remove restriction on printing probe times only during initcalls, since
> initcall_debug now continues to show driver timing info past the boot
> phase.
> 
> Signed-off-by: Todd Poynor <toddpoynor@google.com>
> ---
>  drivers/base/dd.c | 50 +++++++++++++++++++++--------------------------
>  1 file changed, 22 insertions(+), 28 deletions(-)
> 
> Changes from v1:
> * unsigned long long -> s64
> * use ktime_to_us() instead of ktime_to_ns with shift
> * print probe return value
> * drop code that stopped output on end of initcall processing

Reviewed-by: Rob Herring <robh@kernel.org>

      reply	other threads:[~2018-06-25 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21  0:35 [PATCH v2] drivers: base: initcall_debug logs for driver probe times Todd Poynor
2018-06-25 15:20 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180625152055.GA23270@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toddpoynor@gmail.com \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox