From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH v2 06/23] thermal: armada: convert driver to syscon register accesses Date: Tue, 26 Jun 2018 06:37:24 +0300 Message-ID: <20180626033724.q7radxgjeqtsl7ae@tarshish> References: <20180625151239.20976-1-miquel.raynal@bootlin.com> <20180625151239.20976-7-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180625151239.20976-7-miquel.raynal@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Rob Herring , Maxime Chevallier , Eduardo Valentin , David Sniatkiwicz , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Hi Miquel, On Mon, Jun 25, 2018 at 05:12:22PM +0200, Miquel Raynal wrote: > Until recently, only one register was referenced in MVEBU thermal IP > node. Recent changes added a second entry pointing to another > register right next to it. We cannot know for sure that we will not > have to access other registers. That will be actually the case when > overheat interrupt feature will come, where it will be needed to access > DFX registers in the same area. > > This approach is not scalable so intead of adding consinuously memory > areas in the DT (and change de DT bindings, while keeping backward s/de/the/ > compatibility), move the thermal node into a wider syscon from which it > will be possible to also configure the thermal interrupt. > > Signed-off-by: Miquel Raynal baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -