From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 26 Jun 2018 20:55:25 +0530 From: Vinod Subject: Re: [PATCH v3 1/5] dt-bindings: power: reset: Add qcom pon binding Message-ID: <20180626152525.GC22377@vkoul-mobl> References: <20180625063840.30173-1-vkoul@kernel.org> <20180625063840.30173-2-vkoul@kernel.org> <20180625172707.GA24068@rob-hp-laptop> <20180626035110.GD2404@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Rob Herring Cc: linux-input@vger.kernel.org, "open list:THERMAL" , Bjorn Andersson , Dmitry Torokhov , Sebastian Reichel , devicetree@vger.kernel.org, linux-arm-msm List-ID: On 26-06-18, 08:47, Rob Herring wrote: > > > > +-prwrkey: Specifies the subnode pwrkey and should follow the > > > > > > typo > > > > > > Hmmm which one? > > s/prwrkey/pwrkey/ Ah good spot, will fix > > > > + resin { > > > > + compatible = "qcom,pm8941-resin"; > > > > > > Not documented. > > > > qcom,pm8xxx-pwrkey.txt documents this. Subnode documentation is not > > provided here > > Is it new because it is not in any tree I see. Sorry wrong name, it is Documented in Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt and I missed adding qcom,pm8941-resin, will add to this series. Thanks -- ~Vinod