Re: [PATCH 2/2] arm64: tegra: Add CPU nodes to Tegra194 device tree

Mikko Perttunen
2018-06-28T05:57:23Z

On 27.06.2018 19:57, Rob Herring wrote:
> On Wed, Jun 20, 2018 at 03:28:27PM +0300, Mikko Perttunen wrote:
>> Add CPU and PSCI nodes to device tree. The Tegra194 SoC contains
>> eight NVIDIA Carmel CPUs.
>>
>> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
>> ---
>> arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 40 +++++++++++++++++++
>> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 53 ++++++++++++++++++++++++++
>> 2 files changed, 93 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
>> index ecb034177fc2..859ab5af17c1 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
>> @@ -229,6 +229,46 @@
>> };
>> };
>>
>> + cpus {
>> + cpu@0 {
>> + enable-method = "psci";
>> + };
>
> Kind of strange to have this separated out. I guess you have non-PSCI
> firmware too? In any case, unless things have changed, upstream is only
> supporting spin-table or PSCI for arm64. So please combine this with the
> rest of the cpu nodes.

This was copied from older Tegras - we might have had some systems in
the past with non-PSCI firmware, but certainly don't have that anymore.
I'll combine the nodes.

Mikko

>
> Rob
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>