From: Rob Herring <robh@kernel.org>
To: Mikko Perttunen <mperttunen@nvidia.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
jonathanh@nvidia.com, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: tegra: Add CPU nodes to Tegra194 device tree
Date: Wed, 27 Jun 2018 10:57:30 -0600 [thread overview]
Message-ID: <20180627165730.GA15867@rob-hp-laptop> (raw)
In-Reply-To: <20180620122827.14165-2-mperttunen@nvidia.com>
On Wed, Jun 20, 2018 at 03:28:27PM +0300, Mikko Perttunen wrote:
> Add CPU and PSCI nodes to device tree. The Tegra194 SoC contains
> eight NVIDIA Carmel CPUs.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 40 +++++++++++++++++++
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 53 ++++++++++++++++++++++++++
> 2 files changed, 93 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> index ecb034177fc2..859ab5af17c1 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> @@ -229,6 +229,46 @@
> };
> };
>
> + cpus {
> + cpu@0 {
> + enable-method = "psci";
> + };
Kind of strange to have this separated out. I guess you have non-PSCI
firmware too? In any case, unless things have changed, upstream is only
supporting spin-table or PSCI for arm64. So please combine this with the
rest of the cpu nodes.
Rob
next prev parent reply other threads:[~2018-06-27 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 12:28 [PATCH 1/2] dt-bindings: arm: Add compatible string for NVIDIA Carmel Mikko Perttunen
2018-06-20 12:28 ` [PATCH 2/2] arm64: tegra: Add CPU nodes to Tegra194 device tree Mikko Perttunen
2018-06-27 16:57 ` Rob Herring [this message]
2018-06-28 5:57 ` Mikko Perttunen
2018-06-27 16:52 ` [PATCH 1/2] dt-bindings: arm: Add compatible string for NVIDIA Carmel Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627165730.GA15867@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox