From: Vinod <vkoul@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: linux-input@vger.kernel.org, linux-pm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 2/6] power: reset: qcom-pon: Add Qcom PON driver
Date: Thu, 28 Jun 2018 20:33:50 +0530 [thread overview]
Message-ID: <20180628150350.GW22377@vkoul-mobl> (raw)
In-Reply-To: <20180628132754.GV22377@vkoul-mobl>
On 28-06-18, 18:57, Vinod wrote:
> Hi Sebastian,
>
> On 28-06-18, 15:16, Sebastian Reichel wrote:
> > On Thu, Jun 28, 2018 at 06:29:58PM +0530, Vinod wrote:
> > > > >
> > > > > +config POWER_RESET_QCOM_PON
> > > > > + bool "Qualcomm power-on driver"
> > > >
> > > > tristate?
> > >
> > > Hmmm I dont think there is a reason for this not being a module, though
> > > looking at reset driver, bunch of them seem to be inbuilt only.
> > >
> > > Bjorn, do you think we can be module or only inbuilt?
> >
> > Note: If the result is inbuilt only, then you should update the
> > code accordingly (drop MODULE_*, use builtin_platform_driver instead
> > of module_platform_driver, ...
>
> Agreed, either way I will send an update shortly.
Okay discussed with Bjorn and made it tristate. Will send updated
shortly
--
~Vinod
next prev parent reply other threads:[~2018-06-28 15:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 11:52 [PATCH v4 0/6] input: pm8941-pwrkey: Add support for reboot reason Vinod Koul
2018-06-27 11:52 ` [PATCH v4 1/6] dt-bindings: power: reset: Add qcom pon binding Vinod Koul
2018-06-27 11:52 ` [PATCH v4 2/6] power: reset: qcom-pon: Add Qcom PON driver Vinod Koul
2018-06-28 11:59 ` Sebastian Reichel
2018-06-28 12:59 ` Vinod
2018-06-28 13:16 ` Sebastian Reichel
2018-06-28 13:27 ` Vinod
2018-06-28 15:03 ` Vinod [this message]
2018-06-27 11:52 ` [PATCH v4 3/6] dt-bindings: Input: Add additional property to qcom pwrkey Vinod Koul
2018-06-27 11:52 ` [PATCH v4 4/6] input: pm8941-pwrkey: Abstract register offsets and event code Vinod Koul
2018-06-27 11:53 ` [PATCH v4 5/6] dt-bindings: power: reset: qcom: Add resin binding Vinod Koul
2018-06-27 17:26 ` Bjorn Andersson
2018-06-27 11:53 ` [PATCH v4 6/6] input: pm8941-pwrkey: Add resin entry Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628150350.GW22377@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox