From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH v3 0/8] gnss: add new GNSS subsystem Date: Fri, 29 Jun 2018 13:46:46 +0200 Message-ID: <20180629114646.GU629@localhost> References: <20180601082259.17563-1-johan@kernel.org> <20180628120103.GA28131@kroah.com> <20180629094607.GC31718@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180629094607.GC31718@amd> Sender: linux-kernel-owner@vger.kernel.org To: Pavel Machek Cc: Greg Kroah-Hartman , Linus Torvalds , alan@linux.intel.com, Johan Hovold , Rob Herring , Mark Rutland , Andreas Kemnade , Arnd Bergmann , "H . Nikolaus Schaller" , Marcel Holtmann , Sebastian Reichel , Tony Lindgren , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, Jun 29, 2018 at 11:46:07AM +0200, Pavel Machek wrote: > > > > Finally, note that documentation (including kerneldoc) remains to be > > > written, but hopefully this will not hinder review given that the > > > current interfaces are fairly self-describing. > > > > This all looks great. Thanks for doing this work and adding a new > > subsystem for something that has been asked for for many years. > > > > All now merged in my tree, nice job! > > I don't think discussion was finished on this one. > > In particular, we agreed that /dev/gnssrawX would be better device > name, so that we still have place where to put proper abstraction > layer in future. I did not agree with you on that. I said we could consider that name if this was to be changed at all, which I do not think is necessary for the reasons spelled out in this thread. Johan