From: Daniel Mack <daniel@zonque.org>
To: ulf.hansson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com
Cc: robert.jarzmik@free.fr, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: [PATCH 3/7] mmc: pxamci: remove dead code from pxamci_remove()
Date: Fri, 29 Jun 2018 16:47:34 +0200 [thread overview]
Message-ID: <20180629144738.446-4-daniel@zonque.org> (raw)
In-Reply-To: <20180629144738.446-1-daniel@zonque.org>
These gpio assignments don't make sense, as they are not used anywhere.
Remove the dead code.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
drivers/mmc/host/pxamci.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index a826c0e8a096..ee1c32862ef8 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -806,18 +806,12 @@ static int pxamci_probe(struct platform_device *pdev)
static int pxamci_remove(struct platform_device *pdev)
{
struct mmc_host *mmc = platform_get_drvdata(pdev);
- int gpio_cd = -1, gpio_ro = -1, gpio_power = -1;
if (mmc) {
struct pxamci_host *host = mmc_priv(mmc);
mmc_remove_host(mmc);
- if (host->pdata) {
- gpio_cd = host->pdata->gpio_card_detect;
- gpio_ro = host->pdata->gpio_card_ro;
- gpio_power = host->pdata->gpio_power;
- }
if (host->pdata && host->pdata->exit)
host->pdata->exit(&pdev->dev, mmc);
@@ -833,6 +827,7 @@ static int pxamci_remove(struct platform_device *pdev)
mmc_free_host(mmc);
}
+
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2018-06-29 14:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 14:47 [PATCH 0/7] mmc: pxamci: cleanups and minor DT tweaks Daniel Mack
2018-06-29 14:47 ` [PATCH 1/7] mmc: pxamci: remove irq from private context Daniel Mack
2018-06-29 21:14 ` Robert Jarzmik
2018-06-29 14:47 ` [PATCH 2/7] mmc: pxamci: remove dma resources " Daniel Mack
2018-06-29 21:15 ` Robert Jarzmik
2018-06-29 14:47 ` Daniel Mack [this message]
2018-06-29 21:17 ` [PATCH 3/7] mmc: pxamci: remove dead code from pxamci_remove() Robert Jarzmik
2018-06-29 14:47 ` [PATCH 4/7] mmc: pxamci: fix indenting Daniel Mack
2018-06-29 21:20 ` Robert Jarzmik
2018-06-29 14:47 ` [PATCH 5/7] mmc: pxamci: call mmc_of_parse() Daniel Mack
2018-06-30 15:25 ` Robert Jarzmik
2018-06-30 18:07 ` Daniel Mack
2018-06-29 14:47 ` [PATCH 6/7] mmc: pxamci: remove pxa-mmc,gpio-power from devicetree bindings Daniel Mack
2018-06-30 15:25 ` Robert Jarzmik
2018-06-29 14:47 ` [PATCH 7/7] mmc: pxamci: let mmc core handle regulators Daniel Mack
2018-06-30 15:25 ` Robert Jarzmik
2018-06-30 18:08 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629144738.446-4-daniel@zonque.org \
--to=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).