devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: ulf.hansson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com
Cc: robert.jarzmik@free.fr, linux-mmc@vger.kernel.org,
	devicetree@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: [PATCH 6/7] mmc: pxamci: remove pxa-mmc,gpio-power from devicetree bindings
Date: Fri, 29 Jun 2018 16:47:37 +0200	[thread overview]
Message-ID: <20180629144738.446-7-daniel@zonque.org> (raw)
In-Reply-To: <20180629144738.446-1-daniel@zonque.org>

Devicetree-enabled boards should use proper regulators to control the
power of cards, not GPIOs, so let's remove this property. The regulator
properties are are supported by the MMC core and are described in the
generic MMC document:

  Documentation/devicetree/bindings/mmc/mmc.txt

Note that devicetree support for PXA platforms hasn't fully landed yet,
so this binding does not have any users at this point.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 Documentation/devicetree/bindings/mmc/pxa-mmc.txt | 1 -
 drivers/mmc/host/pxamci.c                         | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/pxa-mmc.txt b/Documentation/devicetree/bindings/mmc/pxa-mmc.txt
index b7025de7dced..359b13977f24 100644
--- a/Documentation/devicetree/bindings/mmc/pxa-mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/pxa-mmc.txt
@@ -8,7 +8,6 @@ Required properties:
 
 Optional properties:
 - marvell,detect-delay-ms: sets the detection delay timeout in ms.
-- marvell,gpio-power: GPIO spec for the card power enable pin
 
 This file documents differences between the core properties in mmc.txt
 and the properties used by the pxa-mmc driver.
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index e15708aa77a2..c01d69904e2a 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -612,9 +612,6 @@ static int pxamci_of_init(struct platform_device *pdev,
 		of_get_named_gpio(np, "wp-gpios", 0);
 
 	/* pxa-mmc specific */
-	pdata->gpio_power =
-		of_get_named_gpio(np, "pxa-mmc,gpio-power", 0);
-
 	if (of_property_read_u32(np, "pxa-mmc,detect-delay-ms", &tmp) == 0)
 		pdata->detect_delay_ms = tmp;
 
-- 
2.17.1

  parent reply	other threads:[~2018-06-29 14:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29 14:47 [PATCH 0/7] mmc: pxamci: cleanups and minor DT tweaks Daniel Mack
2018-06-29 14:47 ` [PATCH 1/7] mmc: pxamci: remove irq from private context Daniel Mack
2018-06-29 21:14   ` Robert Jarzmik
2018-06-29 14:47 ` [PATCH 2/7] mmc: pxamci: remove dma resources " Daniel Mack
2018-06-29 21:15   ` Robert Jarzmik
2018-06-29 14:47 ` [PATCH 3/7] mmc: pxamci: remove dead code from pxamci_remove() Daniel Mack
2018-06-29 21:17   ` Robert Jarzmik
2018-06-29 14:47 ` [PATCH 4/7] mmc: pxamci: fix indenting Daniel Mack
2018-06-29 21:20   ` Robert Jarzmik
2018-06-29 14:47 ` [PATCH 5/7] mmc: pxamci: call mmc_of_parse() Daniel Mack
2018-06-30 15:25   ` Robert Jarzmik
2018-06-30 18:07     ` Daniel Mack
2018-06-29 14:47 ` Daniel Mack [this message]
2018-06-30 15:25   ` [PATCH 6/7] mmc: pxamci: remove pxa-mmc,gpio-power from devicetree bindings Robert Jarzmik
2018-06-29 14:47 ` [PATCH 7/7] mmc: pxamci: let mmc core handle regulators Daniel Mack
2018-06-30 15:25   ` Robert Jarzmik
2018-06-30 18:08     ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180629144738.446-7-daniel@zonque.org \
    --to=daniel@zonque.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robert.jarzmik@free.fr \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).