From: Daniel Mack <daniel@zonque.org>
To: ulf.hansson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com
Cc: robert.jarzmik@free.fr, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: [PATCH v2 6/7] mmc: pxamci: remove pxa-mmc,gpio-power from devicetree bindings
Date: Sat, 30 Jun 2018 20:14:04 +0200 [thread overview]
Message-ID: <20180630181405.17630-7-daniel@zonque.org> (raw)
In-Reply-To: <20180630181405.17630-1-daniel@zonque.org>
Devicetree-enabled boards should use proper regulators to control the
power of cards, not GPIOs, so let's remove this property. The regulator
properties are supported by the MMC core and are described in the
generic MMC document:
Documentation/devicetree/bindings/mmc/mmc.txt
Note that devicetree support for PXA platforms hasn't fully landed yet,
so this binding does not have any users at this point.
Signed-off-by: Daniel Mack <daniel@zonque.org>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
Documentation/devicetree/bindings/mmc/pxa-mmc.txt | 2 +-
drivers/mmc/host/pxamci.c | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/pxa-mmc.txt b/Documentation/devicetree/bindings/mmc/pxa-mmc.txt
index f2687752597e..5f5c2bec2b8c 100644
--- a/Documentation/devicetree/bindings/mmc/pxa-mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/pxa-mmc.txt
@@ -8,7 +8,6 @@ Required properties:
Optional properties:
- marvell,detect-delay-ms: sets the detection delay timeout in ms.
-- marvell,gpio-power: GPIO spec for the card power enable pin
In addition to the properties described in this docuent, the details
described in mmc.txt are supported.
@@ -19,6 +18,7 @@ mmc0: mmc@41100000 {
compatible = "marvell,pxa-mmc";
reg = <0x41100000 0x1000>;
interrupts = <23>;
+ vmmc-supply = <&mmc_regulator>;
cd-gpios = <&gpio 23 0>;
wp-gpios = <&gpio 24 0>;
};
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index e046e684b3f9..1e7703116763 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -607,9 +607,6 @@ static int pxamci_of_init(struct platform_device *pdev,
return -ENOMEM;
/* pxa-mmc specific */
- pdata->gpio_power =
- of_get_named_gpio(np, "pxa-mmc,gpio-power", 0);
-
if (of_property_read_u32(np, "pxa-mmc,detect-delay-ms", &tmp) == 0)
pdata->detect_delay_ms = tmp;
--
2.17.1
next prev parent reply other threads:[~2018-06-30 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 18:13 [PATCH v2 0/7] mmc: pxamci: cleanups and minor DT tweaks Daniel Mack
2018-06-30 18:13 ` [PATCH v2 1/7] mmc: pxamci: remove irq from private context Daniel Mack
2018-06-30 18:14 ` [PATCH v2 2/7] mmc: pxamci: remove dma resources " Daniel Mack
2018-06-30 18:14 ` [PATCH v2 3/7] mmc: pxamci: remove dead code from pxamci_remove() Daniel Mack
2018-06-30 18:14 ` [PATCH v2 4/7] mmc: pxamci: fix indenting Daniel Mack
2018-06-30 18:14 ` [PATCH v2 5/7] mmc: pxamci: call mmc_of_parse() Daniel Mack
2018-06-30 18:14 ` Daniel Mack [this message]
2018-06-30 18:14 ` [PATCH v2 7/7] mmc: pxamci: let mmc core handle regulators Daniel Mack
2018-07-02 14:38 ` [PATCH v2 0/7] mmc: pxamci: cleanups and minor DT tweaks Ulf Hansson
2018-07-02 14:43 ` Daniel Mack
2018-07-02 14:47 ` Ulf Hansson
2018-07-02 15:23 ` Robert Jarzmik
2018-07-03 5:35 ` Ulf Hansson
2018-07-03 9:23 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180630181405.17630-7-daniel@zonque.org \
--to=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).