From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [1/3] ARM: dts: imx51-zii-common: create common include dtsi Date: Sun, 1 Jul 2018 16:21:21 +0800 Message-ID: <20180701082119.GH4348@dragon> References: <1529603100-31958-2-git-send-email-andrey.gusakov@cogentembedded.com> <5a3490a5-ee5c-a4da-8b54-b5234b7e50d0@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fabio Estevam Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , Andrey Smirnov , Sascha Hauer , Andrey Gusakov , linux-kernel , Rob Herring , NXP Linux Team , nikita.yoush@yandex.ru, Fabio Estevam , Chris Healy , linux-arm-kernel , Lucas Stach List-Id: devicetree@vger.kernel.org On Wed, Jun 27, 2018 at 02:00:11PM -0300, Fabio Estevam wrote: > On Wed, Jun 27, 2018 at 1:46 PM, Andrey Smirnov > wrote: > > > We are now starting to give Andrey Gusakov conflicting > > recommendations. For the sake of moving forward, can we agree that > > this and similar comments are relatively minor and defer to the > > maintainers to make a call which way to go? > > This way Andrey has a clear way on how to move forward with this set. > > The approach in this patched looked fine to me as well. > > Maybe we can have some feedback from Shawn? I'm overall fine with the approach as well. But I agree with Nikita's comment that having pinctrl definition and usage spread in different files makes reader's life harder. So I would suggest that we have the following properties in imx51-zii-rdu1.dts as well. pinctrl-names = "default"; pinctrl-0 = <&pinctrl_swi2c>; Shawn