From: Eduardo Valentin <edubezval@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Baruch Siach <baruch@tkos.co.il>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-pm@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
David Sniatkiwicz <davidsn@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 06/23] thermal: armada: convert driver to syscon register accesses
Date: Mon, 2 Jul 2018 10:29:19 -0700 [thread overview]
Message-ID: <20180702172918.GA28262@localhost.localdomain> (raw)
In-Reply-To: <20180626092931.7f0f0ad4@xps13>
Miquel,
On Tue, Jun 26, 2018 at 09:29:31AM +0200, Miquel Raynal wrote:
> Hi Baruch,
>
> On Tue, 26 Jun 2018 06:37:24 +0300, Baruch Siach <baruch@tkos.co.il>
> wrote:
>
> > Hi Miquel,
> >
> > On Mon, Jun 25, 2018 at 05:12:22PM +0200, Miquel Raynal wrote:
> > > Until recently, only one register was referenced in MVEBU thermal IP
> > > node. Recent changes added a second entry pointing to another
> > > register right next to it. We cannot know for sure that we will not
> > > have to access other registers. That will be actually the case when
> > > overheat interrupt feature will come, where it will be needed to access
> > > DFX registers in the same area.
> > >
> > > This approach is not scalable so intead of adding consinuously memory
> > > areas in the DT (and change de DT bindings, while keeping backward
> >
> > s/de/the/
>
> Oh and s/intead/instead/ too.
Can you please fix the minor above and also refresh against linus master
branch? Patch does not apply clean anymore.
checking file drivers/thermal/armada_thermal.c
Hunk #3 FAILED at 64.
Hunk #4 succeeded at 89 (offset -1 lines).
Hunk #5 succeeded at 112 (offset -1 lines).
Hunk #6 succeeded at 144 (offset -1 lines).
Hunk #7 succeeded at 165 (offset -1 lines).
Hunk #8 succeeded at 196 (offset -1 lines).
Hunk #9 succeeded at 209 (offset -1 lines).
Hunk #10 succeeded at 218 (offset -1 lines).
Hunk #11 succeeded at 258 (offset -1 lines).
Hunk #12 succeeded at 290 (offset -1 lines).
Hunk #13 succeeded at 303 (offset -1 lines).
Hunk #14 succeeded at 316 (offset -1 lines).
Hunk #15 succeeded at 331 (offset -1 lines).
Hunk #16 succeeded at 347 (offset -1 lines).
Hunk #17 succeeded at 362 (offset -1 lines).
Hunk #18 FAILED at 399.
Hunk #19 succeeded at 400 (offset -31 lines).
Hunk #20 succeeded at 413 with fuzz 1 (offset -31 lines).
Hunk #21 succeeded at 417 (offset -34 lines).
2 out of 21 hunks FAILED
I get the above after applying the first 5 patches of your series.
>
> Thanks for pointing it,
> Miquèl
next prev parent reply other threads:[~2018-07-02 17:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 15:12 [PATCH v2 00/23] Add multi-channel support to Armada thermal driver Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 01/23] thermal: armada: remove useless register accesses Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 02/23] thermal: armada: remove misleading comments Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 03/23] thermal: armada: rename the initialization routine Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 04/23] thermal: armada: dissociate a380 and cp110 ->init() hooks Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 05/23] thermal: armada: average over samples to avoid glitches Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 06/23] thermal: armada: convert driver to syscon register accesses Miquel Raynal
2018-06-26 3:37 ` Baruch Siach
2018-06-26 7:29 ` Miquel Raynal
2018-07-02 17:29 ` Eduardo Valentin [this message]
2018-07-05 12:43 ` Miquel Raynal
2018-07-05 15:53 ` Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 07/23] thermal: armada: use the resource managed registration helper alternative Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 08/23] thermal: armada: add multi-channel sensors support Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 09/23] thermal: armada: remove sensors validity from the IP initialization Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 10/23] thermal: armada: move validity check out of the read function Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 11/23] thermal: armada: get rid of the ->is_valid() pointer Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 12/23] dt-bindings: cp110: rename cp110 syscon file Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 13/23] dt-bindings: ap806: prepare the syscon file to list other syscons nodes Miquel Raynal
2018-07-03 21:07 ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 14/23] dt-bindings: cp110: " Miquel Raynal
2018-06-26 3:35 ` Baruch Siach
2018-06-26 7:34 ` Miquel Raynal
2018-07-03 21:07 ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 15/23] dt-bindings: ap806: add the thermal node in the syscon file Miquel Raynal
2018-07-03 21:13 ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 16/23] dt-bindings: cp110: update documentation since DT de-duplication Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 17/23] dt-bindings: cp110: add the thermal node in the syscon file Miquel Raynal
2018-07-03 21:14 ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 18/23] dt-bindings: thermal: armada: add reference to new bindings Miquel Raynal
2018-07-03 21:30 ` Rob Herring
2018-07-05 10:05 ` Miquel Raynal
2018-07-05 18:03 ` Rob Herring
2018-07-06 6:54 ` Miquel Raynal
2018-07-06 17:51 ` Rob Herring
2018-07-06 7:49 ` Miquel Raynal
2018-07-06 17:56 ` Rob Herring
2018-07-16 14:32 ` Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 19/23] arm64: dts: marvell: rename ap806 syscon node Miquel Raynal
2018-07-03 21:33 ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 20/23] arm64: dts: marvell: move AP806/CP110 thermal nodes into a new syscon Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 21/23] arm64: dts: marvell: add thermal-zone node in ap806 DTSI file Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 22/23] arm64: dts: marvell: add macro to make distinction between node names Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 23/23] arm64: dts: marvell: add thermal-zone node in cp110 DTSI file Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702172918.GA28262@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=catalin.marinas@arm.com \
--cc=davidsn@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).