From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH v2 06/23] thermal: armada: convert driver to syscon register accesses Date: Mon, 2 Jul 2018 10:29:19 -0700 Message-ID: <20180702172918.GA28262@localhost.localdomain> References: <20180625151239.20976-1-miquel.raynal@bootlin.com> <20180625151239.20976-7-miquel.raynal@bootlin.com> <20180626033724.q7radxgjeqtsl7ae@tarshish> <20180626092931.7f0f0ad4@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20180626092931.7f0f0ad4@xps13> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Mark Rutland , Andrew Lunn , Baruch Siach , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Rob Herring , Maxime Chevallier , Nadav Haklai , David Sniatkiwicz , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Miquel, On Tue, Jun 26, 2018 at 09:29:31AM +0200, Miquel Raynal wrote: > Hi Baruch, > = > On Tue, 26 Jun 2018 06:37:24 +0300, Baruch Siach > wrote: > = > > Hi Miquel, > > = > > On Mon, Jun 25, 2018 at 05:12:22PM +0200, Miquel Raynal wrote: > > > Until recently, only one register was referenced in MVEBU thermal IP > > > node. Recent changes added a second entry pointing to another > > > register right next to it. We cannot know for sure that we will not > > > have to access other registers. That will be actually the case when > > > overheat interrupt feature will come, where it will be needed to acce= ss > > > DFX registers in the same area. > > > = > > > This approach is not scalable so intead of adding consinuously memory > > > areas in the DT (and change de DT bindings, while keeping backward = > > = > > s/de/the/ > = > Oh and s/intead/instead/ too. Can you please fix the minor above and also refresh against linus master branch? Patch does not apply clean anymore. checking file drivers/thermal/armada_thermal.c Hunk #3 FAILED at 64. Hunk #4 succeeded at 89 (offset -1 lines). Hunk #5 succeeded at 112 (offset -1 lines). Hunk #6 succeeded at 144 (offset -1 lines). Hunk #7 succeeded at 165 (offset -1 lines). Hunk #8 succeeded at 196 (offset -1 lines). Hunk #9 succeeded at 209 (offset -1 lines). Hunk #10 succeeded at 218 (offset -1 lines). Hunk #11 succeeded at 258 (offset -1 lines). Hunk #12 succeeded at 290 (offset -1 lines). Hunk #13 succeeded at 303 (offset -1 lines). Hunk #14 succeeded at 316 (offset -1 lines). Hunk #15 succeeded at 331 (offset -1 lines). Hunk #16 succeeded at 347 (offset -1 lines). Hunk #17 succeeded at 362 (offset -1 lines). Hunk #18 FAILED at 399. Hunk #19 succeeded at 400 (offset -31 lines). Hunk #20 succeeded at 413 with fuzz 1 (offset -31 lines). Hunk #21 succeeded at 417 (offset -34 lines). 2 out of 21 hunks FAILED I get the above after applying the first 5 patches of your series. > = > Thanks for pointing it, > Miqu=E8l