From: Wolfram Sang <wsa@the-dreams.de>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
benh@kernel.crashing.org, joel@jms.id.au, mark.rutland@arm.com,
gregkh@linuxfoundation.org, rdunlap@infradead.org,
andy.shevchenko@gmail.com, peda@axentia.se
Subject: Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation
Date: Mon, 2 Jul 2018 20:24:34 +0200 [thread overview]
Message-ID: <20180702182434.5wxxszpgpf6wergl@ninjato> (raw)
In-Reply-To: <6713efb9-c4c3-f648-a1e9-7918110091e4@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
> > > + if (msg->flags & I2C_M_RD)
> > > + cmd |= I2C_CMD_READ;
> > Since you support MANGLING, I'd think you can easily support
> > I2C_M_REV_DIR_ADDR here, too?
>
> Hm, I don't really understand the purpose of that flag. From the docs:
>
> This toggles the Rd/Wr flag. That is, if you want to do a write, but
> need to emit an Rd instead of a Wr, or vice versa, you set this
> flag. For example:
> S Addr Rd [A] Data [A] Data [A] ... [A] Data [A] P
>
> I don't think our hardware supports this type of operation.
I'd think something like this should do:
if (msg->flags & I2C_M_REV_DIR_ADDR)
cmd ^= I2C_CMD_READ;
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-07-02 18:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 19:36 [PATCH v10 0/7] i2c: Add FSI-attached I2C master algorithm Eddie James
2018-06-13 19:36 ` [PATCH v10 1/7] dt-bindings: i2c: Add FSI-attached I2C master dt binding documentation Eddie James
2018-06-26 2:39 ` Wolfram Sang
2018-06-13 19:36 ` [PATCH v10 2/7] i2c: Add FSI-attached I2C master algorithm Eddie James
2018-06-13 19:36 ` [PATCH v10 3/7] i2c: fsi: Add port structures Eddie James
2018-06-20 3:34 ` Benjamin Herrenschmidt
2018-06-20 3:59 ` Joel Stanley
2018-06-13 19:36 ` [PATCH v10 4/7] i2c: fsi: Add abort and hardware reset procedures Eddie James
2018-06-26 2:38 ` Wolfram Sang
2018-06-27 13:48 ` Eddie James
2018-07-02 18:15 ` Wolfram Sang
2018-07-05 18:50 ` Eddie James
2018-07-05 22:06 ` Wolfram Sang
2018-06-13 19:36 ` [PATCH v10 5/7] i2c: fsi: Add transfer implementation Eddie James
2018-06-26 2:38 ` Wolfram Sang
2018-06-27 13:21 ` Eddie James
2018-07-02 18:24 ` Wolfram Sang [this message]
2018-07-05 18:52 ` Eddie James
2018-07-05 21:59 ` Wolfram Sang
2018-06-13 19:36 ` [PATCH v10 6/7] i2c: fsi: Add I2C master locking Eddie James
2018-06-13 19:36 ` [PATCH v10 7/7] i2c: fsi: Add bus recovery Eddie James
2018-06-26 2:38 ` Wolfram Sang
2018-06-27 13:32 ` Eddie James
2018-07-02 18:16 ` Wolfram Sang
2018-06-14 9:05 ` [PATCH v10 0/7] i2c: Add FSI-attached I2C master algorithm Andy Shevchenko
2018-06-18 4:53 ` Joel Stanley
2018-06-26 2:39 ` Wolfram Sang
2018-06-27 13:53 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702182434.5wxxszpgpf6wergl@ninjato \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox