* [PATCH] ARM: dts: am335x-bone-common: Fix mmc0 Write Protect
@ 2018-07-02 20:21 Robert Nelson
2018-07-03 6:24 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Robert Nelson @ 2018-07-02 20:21 UTC (permalink / raw)
To: tony, devicetree
Cc: Drew Fustini, Faiz Abbas, Jason Kridner, linux-omap,
Robert Nelson, linux-arm-kernel
Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux
settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape
header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write
Protect.
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
CC: Faiz Abbas <faiz_abbas@ti.com>
CC: Tony Lindgren <tony@atomide.com>
CC: Jason Kridner <jkridner@beagleboard.org>
CC: Drew Fustini <drew@beagleboard.org>
---
arch/arm/boot/dts/am335x-bone-common.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index f9e8667f5886..73b514dddf65 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -168,7 +168,6 @@
AM33XX_IOPAD(0x8f0, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_dat3.mmc0_dat3 */
AM33XX_IOPAD(0x904, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_cmd.mmc0_cmd */
AM33XX_IOPAD(0x900, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_clk.mmc0_clk */
- AM33XX_IOPAD(0x9a0, PIN_INPUT | MUX_MODE4) /* mcasp0_aclkr.mmc0_sdwp */
>;
};
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: am335x-bone-common: Fix mmc0 Write Protect
2018-07-02 20:21 [PATCH] ARM: dts: am335x-bone-common: Fix mmc0 Write Protect Robert Nelson
@ 2018-07-03 6:24 ` Tony Lindgren
2018-07-03 6:31 ` Faiz Abbas
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2018-07-03 6:24 UTC (permalink / raw)
To: Robert Nelson
Cc: devicetree, Drew Fustini, Faiz Abbas, Jason Kridner, linux-omap,
linux-arm-kernel
* Robert Nelson <robertcnelson@gmail.com> [180702 20:24]:
> Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux
> settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape
> header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write
> Protect.
Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for
it.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: am335x-bone-common: Fix mmc0 Write Protect
2018-07-03 6:24 ` Tony Lindgren
@ 2018-07-03 6:31 ` Faiz Abbas
2018-07-03 10:23 ` Robert Nelson
0 siblings, 1 reply; 4+ messages in thread
From: Faiz Abbas @ 2018-07-03 6:31 UTC (permalink / raw)
To: Tony Lindgren, Robert Nelson
Cc: Drew Fustini, devicetree, linux-omap, linux-arm-kernel,
Jason Kridner
Hi,
On Tuesday 03 July 2018 11:54 AM, Tony Lindgren wrote:
> * Robert Nelson <robertcnelson@gmail.com> [180702 20:24]:
>> Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux
>> settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape
>> header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write
>> Protect.
>
> Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for
> it.
>
The evm sk sdwp needs to be removed as well. I guess I'll post a
separate patch as this is already applied.
Thanks,
Faiz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: am335x-bone-common: Fix mmc0 Write Protect
2018-07-03 6:31 ` Faiz Abbas
@ 2018-07-03 10:23 ` Robert Nelson
0 siblings, 0 replies; 4+ messages in thread
From: Robert Nelson @ 2018-07-03 10:23 UTC (permalink / raw)
To: Faiz Abbas
Cc: devicetree, Tony Lindgren, Drew Fustini, Jason Kridner,
linux-omap,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Tue, Jul 3, 2018 at 1:31 AM, Faiz Abbas <faiz_abbas@ti.com> wrote:
> Hi,
>
> On Tuesday 03 July 2018 11:54 AM, Tony Lindgren wrote:
>> * Robert Nelson <robertcnelson@gmail.com> [180702 20:24]:
>>> Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux
>>> settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape
>>> header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write
>>> Protect.
>>
>> Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for
>> it.
>>
>
> The evm sk sdwp needs to be removed as well. I guess I'll post a
> separate patch as this is already applied.
Yeah, i don't have an evm sk, while i found found one schematic that
made it look okay, wasn't 100% sure on all the revisions..
Regards,
--
Robert Nelson
https://rcn-ee.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-03 10:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-02 20:21 [PATCH] ARM: dts: am335x-bone-common: Fix mmc0 Write Protect Robert Nelson
2018-07-03 6:24 ` Tony Lindgren
2018-07-03 6:31 ` Faiz Abbas
2018-07-03 10:23 ` Robert Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).