public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, p.zabel@pengutronix.de, vz@mleia.com,
	Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property
Date: Tue, 3 Jul 2018 16:21:42 -0600	[thread overview]
Message-ID: <20180703222142.GA15061@rob-hp-laptop> (raw)
In-Reply-To: <1530054453-10393-1-git-send-email-festevam@gmail.com>

On Tue, Jun 26, 2018 at 08:07:33PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Some SoCs (like i.MX53) need to specify the SRAM clock in the
> device tree via the clocks property.
> 
> Add an entry to the optional property section.
> 
> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes since v1:
> - Add space before : and use the more common "list of phandle
> and clock specifier pairs" term - Vladimir
> 
>  Documentation/devicetree/bindings/sram/sram.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt
> index 267da44..ae6ca34 100644
> --- a/Documentation/devicetree/bindings/sram/sram.txt
> +++ b/Documentation/devicetree/bindings/sram/sram.txt
> @@ -50,6 +50,8 @@ Optional properties in the area nodes:
>  		 manipulation of the page attributes.
>  - label : the name for the reserved partition, if omitted, the label
>            is taken from the node name excluding the unit address.
> +- clocks : a list of phandle and clock specifier pairs that controls the
> +	   SRAM clock.

A list controlling THE (single) SRAM clock?

Once we start needing clocks, power, or other setup, we really should 
have specific compatible strings (and binding docs) for the SRAM. I'll 
take a single clock though.

Rob

  reply	other threads:[~2018-07-03 22:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26 23:07 [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property Fabio Estevam
2018-07-03 22:21 ` Rob Herring [this message]
2018-07-03 22:41   ` Fabio Estevam
2018-07-04  6:40   ` Vladimir Zapolskiy
2018-07-05 17:18     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703222142.GA15061@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox