Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

Marco Felsch
2018-07-31T07:01:36Z

Hi Mauro,

On 18-07-30 15:18, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:50 +0200
> Marco Felsch <m.felsch@pengutronix.de> escreveu:
>
> > From: Javier Martinez Canillas <javierm@redhat.com>
> >
> > Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> > added input signals support for the tvp5150, but the approach was found
> > to be incorrect so the corresponding DT binding commit 82c2ffeb217a
> > ("[media] tvp5150: document input connectors DT bindings") was reverted.
> >
> > This left the driver with an undocumented (and wrong) DT parsing logic,
> > so lets get rid of this code as well until the input connectors support
> > is implemented properly.
> >
> > It's a partial revert due other patches added on top of mentioned commit
> > not allowing the commit to be reverted cleanly anymore. But all the code
> > related to the DT parsing logic and input entities creation are removed.
> >
> > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > [m.felsch@pengutronix.de: rm TVP5150_INPUT_NUM define]
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
>
> ...
>
> > -static int tvp5150_registered(struct v4l2_subdev *sd)
> > -{
> > -#ifdef CONFIG_MEDIA_CONTROLLER
> > - struct tvp5150 *decoder = to_tvp5150(sd);
> > - int ret = 0;
> > - int i;
> > -
> > - for (i = 0; i < TVP5150_INPUT_NUM; i++) {
> > - struct media_entity *input = &decoder->input_ent[i];
> > - struct media_pad *pad = &decoder->input_pad[i];
> > -
> > - if (!input->name)
> > - continue;
> > -
> > - decoder->input_pad[i].flags = MEDIA_PAD_FL_SOURCE;
> > -
> > - ret = media_entity_pads_init(input, 1, pad);
> > - if (ret < 0)
> > - return ret;
> > -
> > - ret = media_device_register_entity(sd->v4l2_dev->mdev, input);
> > - if (ret < 0)
> > - return ret;
> > -
> > - ret = media_create_pad_link(input, 0, &sd->entity,
> > - DEMOD_PAD_IF_INPUT, 0);
> > - if (ret < 0) {
> > - media_device_unregister_entity(input);
> > - return ret;
> > - }
> > - }
> > -#endif
>
> Hmm... I suspect that reverting this part may cause problems for drivers
> like em28xx when compiled with MC, as they rely that the supported demods
> will have 3 pads (DEMOD_NUM_PADS).

Please, can you test this for me? I have no such usb device.
Using the DEMOD_NUM_PADS looked wrong to me since the tvp5150 has more
than one input pad.

Thanks,
Marco

> Thanks,
> Mauro
>