From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Robin Gong <yibin.gong@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Anson Huang <anson.huang@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
Date: Wed, 4 Jul 2018 08:56:06 +0200 [thread overview]
Message-ID: <20180704085606.78bb104b@karo-electronics.de> (raw)
In-Reply-To: <1530697336.15665.43.camel@nxp.com>
Hi,
On Wed, 4 Jul 2018 01:42:54 +0000 Robin Gong wrote:
> On 二, 2018-07-03 at 08:10 -0300, Fabio Estevam wrote:
> > Hi Anson,
> >
> > On Tue, Jul 3, 2018 at 4:44 AM, Anson Huang <anson.huang@nxp.com>
> > wrote:
> >
> > >
> > > It is NOT easy to identify which switch is critical or NOT, and
> > > different platforms
> > > have different board design, it will introduce many platform
> > > specified code, so I think
> > > just revert the pfuze100 switch enable/disable patch should be OK
> > > for now.
> > I have sent the pfuze100 regulator patch revert and it is linux-next
> > now. Should probably reach 4.18-rc4.
> >
> > >
> > > After a couple of release cycles, add the pfuze100 switch
> > > enable/disable patch
> > > back to support this feature, I believe users should switch to new
> > > dtb with "regulator-always-on"
> > > existing already.
> > That will still break old dtb compatibility.
> >
> > You cannot force users to use "regulator-always-on" and the old dtbs
> > need to always work.
> >
> > So whatever new feature you need to introduce it needs to be done in
> > such a way that the existing dtb's will continue working.
> But actually existing dtb is not right since the critical power rail
> missing 'regulator-always-on'. It's a fix patch for dts, not related
> with following dtb/kernel break rules, just a simple dts patch. Why
> should we make promise for the wrong dtbs?
>
Because they are living in the outside world on real devices.
Lothar Waßmann
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-07-04 6:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 12:34 [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on Robin Gong
2018-06-25 5:53 ` Anson Huang
2018-07-01 9:34 ` Shawn Guo
2018-07-01 23:32 ` Fabio Estevam
2018-07-02 0:53 ` Anson Huang
2018-07-02 0:54 ` Fabio Estevam
2018-07-02 0:57 ` Anson Huang
2018-07-02 1:00 ` Fabio Estevam
2018-07-02 1:03 ` Anson Huang
2018-07-02 1:05 ` Fabio Estevam
2018-07-02 1:09 ` Anson Huang
2018-07-02 1:17 ` Fabio Estevam
2018-07-02 1:19 ` Anson Huang
2018-07-02 2:12 ` Robin Gong
2018-07-02 23:14 ` Fabio Estevam
2018-07-03 5:38 ` Shawn Guo
2018-07-03 7:44 ` Anson Huang
2018-07-03 11:10 ` Fabio Estevam
2018-07-04 1:42 ` Robin Gong
2018-07-04 6:56 ` Lothar Waßmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704085606.78bb104b@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).