* [PATCH v4 3/3] iio: hx711: warning in dt binding example doc
@ 2018-07-04 12:37 Andreas Klinger
2018-07-05 21:32 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Klinger @ 2018-07-04 12:37 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, robh+dt, mark.rutland, mchehab,
davem, gregkh, akpm, linus.walleij, rdunlap, devicetree,
linux-iio, linux-kernel
device tree compiler (dtc) gives a warning if a device node has "@" with a
following number as it's name but no reg property.
fix the example in the documentation of avia,hx711 to conform to dtc
behavior
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
index 4bee51d536e1..b218e093b55a 100644
--- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
+++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
@@ -18,7 +18,7 @@ Optional properties:
high time of 50 microseconds.
Example:
-weight@0 {
+weight {
compatible = "avia,hx711";
sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 3/3] iio: hx711: warning in dt binding example doc
2018-07-04 12:37 [PATCH v4 3/3] iio: hx711: warning in dt binding example doc Andreas Klinger
@ 2018-07-05 21:32 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2018-07-05 21:32 UTC (permalink / raw)
To: Andreas Klinger
Cc: jic23, knaack.h, lars, pmeerw, mark.rutland, mchehab, davem,
gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio,
linux-kernel
On Wed, Jul 04, 2018 at 02:37:19PM +0200, Andreas Klinger wrote:
> device tree compiler (dtc) gives a warning if a device node has "@" with a
> following number as it's name but no reg property.
>
> fix the example in the documentation of avia,hx711 to conform to dtc
> behavior
Capitalization and punctuation needed.
The subject could be more specific. Perhaps "... fix spurious
unit-address in example"
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> index 4bee51d536e1..b218e093b55a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> @@ -18,7 +18,7 @@ Optional properties:
> high time of 50 microseconds.
>
> Example:
> -weight@0 {
> +weight {
> compatible = "avia,hx711";
> sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
> --
> 2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-05 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-04 12:37 [PATCH v4 3/3] iio: hx711: warning in dt binding example doc Andreas Klinger
2018-07-05 21:32 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).