From: Rob Herring <robh@kernel.org>
To: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com
Subject: Re: [PATCH v2] pinctrl: at91-pio4: add support for drive strength
Date: Thu, 5 Jul 2018 12:04:57 -0600 [thread overview]
Message-ID: <20180705180457.GA5809@rob-hp-laptop> (raw)
In-Reply-To: <20180629081533.31885-1-ludovic.desroches@microchip.com>
On Fri, Jun 29, 2018 at 10:15:33AM +0200, Ludovic Desroches wrote:
> Add support for the drive strength configuration. Usually, this value is
> expressed in mA. Since the numeric value depends on VDDIOP voltage, a
> value we can't retrieve at runtime, the controller uses low, medium and
> high to define the drive strength.
>
> The PIO controller accepts two values for the low drive configuration: 0
> and 1. Most of the time, we don't care about the drive strength. So we
> keep the default value which is 0. The drive strength is advertised
> through the sysfs only when it has been explicitly set in the device
> tree i.e. if its value is different from 0.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
>
> Changes:
> - v2: use atmel,drive-strength property instead of drive-strengh one
> since it is not expressend in mA and there is no way to retrieve this
> value at runtime.
> - v1: https://www.spinics.net/lists/linux-gpio/msg27789.html
>
> .../bindings/pinctrl/atmel,at91-pio4-pinctrl.txt | 3 ++
> drivers/pinctrl/pinctrl-at91-pio4.c | 42 ++++++++++++++++++++++
> include/dt-bindings/pinctrl/at91.h | 4 +++
> 3 files changed, 49 insertions(+)
For the DT parts,
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2018-07-05 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 8:15 [PATCH v2] pinctrl: at91-pio4: add support for drive strength Ludovic Desroches
2018-07-05 18:04 ` Rob Herring [this message]
2018-07-09 13:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705180457.GA5809@rob-hp-laptop \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox