Re: [PATCH v4 1/2] gpio: mediatek: add driver for MT7621

Linus Walleij
2018-07-09T11:45:22Z

On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:

> Add driver support for gpio of MT7621 SoC.
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> Reviewed-by: NeilBrown <neil@brown.name>

This is looking really good.

Patch applied: anything remaining can surely be patched up
in-tree.

> +/*
> + * Copyright (C) 2009-2011 Gabor Juhos <juhosg@openwrt.org>
> + * Copyright (C) 2013 John Crispin <blogic@openwrt.org>
> + */

All OpenWRT drivers are moving upstream and I like it :)
Gabo and John wrote like 90% of them on their own :D

> +#define GPIO_BANK_WIDE 0x04

Nitpick: we usually call this "stride" rather than "wide".
I changed it while applying the patch.

Yours,
Linus Walleij