From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: matti.vaittinen@fi.rohmeurope.com,
"Michael Turquette" <mturquette@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
sboyd@kernel.org, "Mark Rutland" <mark.rutland@arm.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
chenjh@rock-chips.com,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-clk@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v10 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC
Date: Fri, 6 Jul 2018 07:09:13 +0100 [thread overview]
Message-ID: <20180706060913.GU496@dell> (raw)
In-Reply-To: <CAFqH_53DbfFTRt2xST6RXg_qu0+LayXjQL2y024We1LHGB3yQA@mail.gmail.com>
On Thu, 05 Jul 2018, Enric Balletbo Serra wrote:
> Missatge de Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> del
> dia dj., 5 de jul. 2018 a les 16:32:
> >
> > ROHM BD71837 PMIC MFD driver providing interrupts and support
> > for three subsystems:
> > - clk
> > - Regulators
> > - input/power-key
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > drivers/mfd/Kconfig | 13 ++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/rohm-bd718x7.c | 198 +++++++++++++++++++++++
> > include/linux/mfd/rohm-bd718x7.h | 333 +++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 545 insertions(+)
> > create mode 100644 drivers/mfd/rohm-bd718x7.c
> > create mode 100644 include/linux/mfd/rohm-bd718x7.h
[snipping ~550 lines of code]
> The main changes I requested are done so I think you can maintain my
> reviewed-by.
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks for your review, it's much appreciated.
In future would you mind trimming your mails back to only include
relevant sections please? Going through ~550 lines of code page by
page trying to find your response was a little painful. TIA.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-07-06 6:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 14:31 [PATCH v10 0/2] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver Matti Vaittinen
2018-07-05 14:32 ` [PATCH v10 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC Matti Vaittinen
2018-07-05 14:41 ` Enric Balletbo Serra
2018-07-06 6:09 ` Lee Jones [this message]
2018-07-06 10:23 ` Matti Vaittinen
2018-07-06 10:56 ` Lee Jones
2018-07-12 13:00 ` Lee Jones
2018-07-17 7:12 ` Matti Vaittinen
2018-07-30 6:52 ` Matti Vaittinen
2018-07-05 14:32 ` [PATCH v10 2/2] mfd: bd71837: Devicetree bindings " Matti Vaittinen
2018-07-05 20:39 ` Rob Herring
2018-07-12 12:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706060913.GU496@dell \
--to=lee.jones@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=kstewart@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).