public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod <vkoul@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-input@vger.kernel.org, linux-pm@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 3/6] dt-bindings: Input: Add additional property to qcom pwrkey
Date: Sat, 7 Jul 2018 10:45:44 +0530	[thread overview]
Message-ID: <20180707051544.GX22377@vkoul-mobl> (raw)
In-Reply-To: <20180628150850.15358-4-vkoul@kernel.org>

Hi Dmitry,

On 28-06-18, 20:38, Vinod Koul wrote:
> Pwrkey and reset have similar properties so add additional
> property for linux,code to use the code for sending events.

Can you please review the input patches.

> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
> index 07bf55f6e0b9..bf719396eadd 100644
> --- a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
> +++ b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
> @@ -32,6 +32,14 @@ PROPERTIES
>  	Definition: presence of this property indicates that the KPDPWR_N pin
>  		    should be configured for pull up.
>  
> +- linux,code:
> +	Usage: optional
> +	Value type: <u32>
> +	Definition: The input key-code associated with the power key.
> +		    Use the linux event codes defined in
> +		    include/dt-bindings/input/linux-event-codes.h
> +		    When property is omitted KEY_POWER is assumed.
> +
>  EXAMPLE
>  
>  	pwrkey@800 {
> @@ -40,4 +48,5 @@ EXAMPLE
>  		interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
>  		debounce = <15625>;
>  		bias-pull-up;
> +		linux,code = <KEY_POWER>;
>  	};
> -- 
> 2.14.4

-- 
~Vinod

  reply	other threads:[~2018-07-07  5:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 15:08 [PATCH v5 0/6] input: pm8941-pwrkey: Add support for reboot reason Vinod Koul
2018-06-28 15:08 ` [PATCH v5 1/6] dt-bindings: power: reset: Add qcom pon binding Vinod Koul
2018-07-03 17:19   ` Rob Herring
2018-07-06 13:57   ` Sebastian Reichel
2018-06-28 15:08 ` [PATCH v5 2/6] power: reset: qcom-pon: Add Qcom PON driver Vinod Koul
2018-07-06  6:33   ` Vinod
2018-07-06 13:58   ` Sebastian Reichel
2018-06-28 15:08 ` [PATCH v5 3/6] dt-bindings: Input: Add additional property to qcom pwrkey Vinod Koul
2018-07-07  5:15   ` Vinod [this message]
2018-07-30 13:55     ` Vinod
2018-06-28 15:08 ` [PATCH v5 4/6] input: pm8941-pwrkey: Abstract register offsets and event code Vinod Koul
2018-06-28 15:08 ` [PATCH v5 5/6] dt-bindings: power: reset: qcom: Add resin binding Vinod Koul
2018-07-03 17:19   ` Rob Herring
2018-07-07  5:14   ` Vinod
2018-07-07 20:24     ` Sebastian Reichel
2018-06-28 15:08 ` [PATCH v5 6/6] input: pm8941-pwrkey: Add resin entry Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180707051544.GX22377@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox