devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Neeraj Dantu <dantuguf14105@gmail.com>
Cc: devicetree@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	Jason Kridner <jkridner@gmail.com>,
	Neeraj Dantu <neeraj.dantu@octavosystems.com>,
	linux-omap@vger.kernel.org,
	Robert Nelson <robertcnelson@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] Add DT support for Octavo Systems OSD3358-SM-RED based on TI AM335x
Date: Mon, 9 Jul 2018 12:43:04 +0100	[thread overview]
Message-ID: <20180709114304.GE6920@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180706200051.1115-1-neeraj.dantu@octavosystems.com>

On Fri, Jul 06, 2018 at 08:00:51PM +0000, Neeraj Dantu wrote:
> +&lcdc {
> +	status = "okay";
> +
> +	/* If you want to get 24 bit RGB and 16 BGR mode instead of
> +	 * current 16 bit RGB and 24 BGR modes, set the propety
> +	 * below to "crossed" and uncomment the video-ports -property
> +	 * in tda19988 node.
> +	 */
> +	blue-and-red-wiring = "straight";
...
> +&i2c0 {
> +	tda19988: tda19988 {

This should not be "tda19988" as the node name - DT requires generic
names, like "hdmi-encoder".

...
> +		/* Convert 24bit BGR to RGB, e.g. cross red and blue wiring */
> +		/* video-ports = <0x234501>; */

Please explain more what's going on here.

Can you set 24-bit RGB mode with the above configuration - presumably
the colours will come out wrong?

Exactly what is the wiring between the lcdc and tda998x?

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up

  parent reply	other threads:[~2018-07-09 11:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 20:00 [PATCH v2] Add DT support for Octavo Systems OSD3358-SM-RED based on TI AM335x Neeraj Dantu
2018-07-09 10:46 ` Tony Lindgren
2018-07-09 10:50   ` Tony Lindgren
2018-07-09 11:43 ` Russell King - ARM Linux [this message]
     [not found]   ` <CADO55X8_tbz-O8AuHwqCGnV0g2oDiGHzAug6g3PFqRth5U2H=w@mail.gmail.com>
2018-07-10  8:26     ` Russell King - ARM Linux
2018-07-10 20:54       ` Neeraj Kumar Reddy Dantu
2018-07-10 23:17         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709114304.GE6920@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=dantuguf14105@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jkridner@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=neeraj.dantu@octavosystems.com \
    --cc=robertcnelson@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).