From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v11 5/8] i2c: fsi: Add transfer implementation Date: Tue, 10 Jul 2018 00:41:14 +0200 Message-ID: <20180709224114.4h47enyt4tucqcou@ninjato> References: <1530816030-13010-1-git-send-email-eajames@linux.vnet.ibm.com> <1530816030-13010-6-git-send-email-eajames@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4ypmot53gvpiu2yo" Return-path: Content-Disposition: inline In-Reply-To: <1530816030-13010-6-git-send-email-eajames@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: Eddie James Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, benh@kernel.crashing.org, joel@jms.id.au, mark.rutland@arm.com, gregkh@linuxfoundation.org, rdunlap@infradead.org, andy.shevchenko@gmail.com, peda@axentia.se List-Id: devicetree@vger.kernel.org --4ypmot53gvpiu2yo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + cmd |= FIELD_PREP(I2C_CMD_ADDR, msg->addr >> 1); I just noticed this and wonder: Don't you need the LSB of the address? It is not the RW flag, this is encoded in msg->flags. Also, no seperate handling for 10 bit addresses? Technically, 7-bit 0x50 is different on the wire from 10-bit 0x050. This is minor, though. There are no 10-bit devices out there. Still, did you test 10-bit support? Rest looks good. --4ypmot53gvpiu2yo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAltD5IoACgkQFA3kzBSg KbZJ6RAAoLCJ9apVqLEc7GDPJY2mLHft6olFHgNIy0dPlaZ/cNNEcbDRZusWNeU9 x2HKAqPCEkfiCIEhvOU+BVAje54YhZyldfvbtK6pkWah4qNeTgRMeHnGLEyQU/EJ 8ig76atDgt/NewStqm/+Rrof6W7jDY20ZWNBdN4DyIr6RFfjb9idbtjj9HgNJ+a8 Wwptu/LwTKsYYyiHuNKl6l4UvXJcsjTqH/NO1vHaFR6nq/1yEly0CwZPzb7fse1Y 6jNHQc9LlI+teCbZqkGYB638WUioeFkDlwgdnAyO369P/zDQfCa3RmAQ8aEOmPFu TTODXkF+a+28EA9fvxlxlDIYUwrY8f7LY2aIHruosXYGjBwi15tLOnS7SnXkY2MD SygxZGkPMabvYTLLS3xPsx5OZOC4yvFWURiIDvA34xCHvFqeoQuvIk96EoH3nC2o TY5TPbrZZfS65ahcZzZTRRwf1LkWpybzsy8p+8kbcR1xOCPWm/ak955BLeHSNomC NrZMYMSRjZ8heAFetjRoUb2pKTm8XW+DeaYkAMlYZg4yhkX+pXhazsBnaFDC5QGW X5nqk8/D3QjalTgHTUqDjoezvt1qi1g5QFUWHcbtKSn/RsbkL3E0d7DLvEqQagzY CA8Nnsj2IG1WgfRpYwbx5WQHMFCEYT6t6yz2j6LZgsAox/fa1pI= =/cd/ -----END PGP SIGNATURE----- --4ypmot53gvpiu2yo--