From: Niklas Cassel <niklas.cassel@linaro.org>
To: Ilia Lin <ilialin@codeaurora.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org, robh@kernel.org,
mark.rutland@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ilia.lin@gmail.com
Subject: Re: [PATCH v11 2/2] dt: qcom: Add qcom-cpufreq-kryo driver configuration
Date: Tue, 10 Jul 2018 11:29:00 +0200 [thread overview]
Message-ID: <20180710092900.GA26718@centauri.lan> (raw)
In-Reply-To: <1527081091-13389-3-git-send-email-ilialin@codeaurora.org>
On Wed, May 23, 2018 at 04:11:31PM +0300, Ilia Lin wrote:
> 1. Add NVMEM node for the speedbin
> 2. Add definitions for all possible MSM8996 CPU OPPs.
> The qcom-cpufreq-kryo driver will select the appropriate subset.
>
> Signed-off-by: Ilia Lin <ilialin@codeaurora.org>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 281 ++++++++++++++++++++++++++--
> 2 files changed, 270 insertions(+), 13 deletions(-)
>
Hello Ilia, Viresh
I tried this patch series (together with you cpu clock driver).
The first problem is that the driver fails to create debugfs entries.
The second problem appears to be that it runs on unlisted frequency.
Is this simply because of missing entries in the opp table?
[ 4.538513] cpu cpu1: opp_list_debug_create_link: Failed to create link
[ 4.538567] cpu cpu1: _add_opp_dev: Failed to register opp debugfs (-12)
[ 4.544514] cpufreq: cpufreq_online: CPU0: Running at unlisted freq: 614400 KHz
[ 4.551441] cpufreq: cpufreq_online: CPU0: Unlisted initial frequency changed to: 652800 KHz
[ 4.563219] cpu cpu3: opp_list_debug_create_link: Failed to create link
[ 4.566937] cpu cpu3: _add_opp_dev: Failed to register opp debugfs (-12)
[ 4.573489] cpufreq: cpufreq_online: CPU2: Running at unlisted freq: 19200 KHz
[ 4.580368] cpufreq: cpufreq_online: CPU2: Unlisted initial frequency changed to: 307200 KHz
Kind regards,
Niklas
next prev parent reply other threads:[~2018-07-10 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 13:11 [PATCH v11 0/2] CPU scaling support for msm8996 DT Ilia Lin
2018-05-23 13:11 ` [PATCH v11 1/2] dt: qcom: Add opp and thermal to the msm8996 Ilia Lin
2018-05-23 13:11 ` [PATCH v11 2/2] dt: qcom: Add qcom-cpufreq-kryo driver configuration Ilia Lin
2018-07-10 9:29 ` Niklas Cassel [this message]
2018-07-10 12:43 ` Ilia Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710092900.GA26718@centauri.lan \
--to=niklas.cassel@linaro.org \
--cc=andy.gross@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ilia.lin@gmail.com \
--cc=ilialin@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).